[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 114336: Install all includes in a KF5 dir
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2013-12-06 16:19:15
Message-ID: 20131206161915.15088.93048 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 6, 2013, 5:06 p.m., Michael Palimaka wrote:
> > kde-modules/KDEInstallDirs.cmake, line 131
> > <http://git.reviewboard.kde.org/r/114336/diff/1/?file=223093#file223093line131>
> >
> > Is the capitalisation intentional? Most other stuff seems to be in lowercase.
It was agreed to use "KF5" in \
http://thread.gmane.org/gmane.comp.kde.devel.frameworks/7463/focus=7934
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114336/#review45274
-----------------------------------------------------------
On Dec. 6, 2013, 5 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114336/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 5 p.m.)
>
>
> Review request for KDE Frameworks and Stephen Kelly.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Install all includes in a KF5 dir. This is the first step to implement the header \
> policy discussed on kde-frameworks-devel.
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake d94adcf
>
> Diff: http://git.reviewboard.kde.org/r/114336/diff/
>
>
> Testing
> -------
>
> Removed install dir, then rebuilt kdelibs, kactivities, kde-runtime, \
> plasma-framework, kde-workspace, libnm-qt and plasma-nm
>
> Thanks,
>
> Aurélien Gâteau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114336/">http://git.reviewboard.kde.org/r/114336/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 6th, 2013, 5:06 p.m. CET, <b>Michael \
Palimaka</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114336/diff/1/?file=223093#file223093line131" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kde-modules/KDEInstallDirs.cmake</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">131</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">_set_fancy</span><span class="p">(</span><span \
class="s">INCLUDE_INSTALL_DIR</span> <span class="s2">"include<span \
class="hl">"</span></span><span class="hl"> </span> \
<span class="s2">"The install dir for header files"</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">131</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="nb">_set_fancy</span><span \
class="p">(</span><span class="s">INCLUDE_INSTALL_DIR</span> <span \
class="s2">"include<span class="hl">/KF5"</span></span> \
<span class="s2">"The install dir for header files"</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is the capitalisation \
intentional? Most other stuff seems to be in lowercase.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was \
agreed to use "KF5" in \
http://thread.gmane.org/gmane.comp.kde.devel.frameworks/7463/focus=7934</pre> <br />
<p>- Aurélien</p>
<br />
<p>On December 6th, 2013, 5 p.m. CET, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Stephen Kelly.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2013, 5 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Install all includes in a KF5 dir. This is the first step to implement \
the header policy discussed on kde-frameworks-devel.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed install dir, then rebuilt kdelibs, kactivities, kde-runtime, \
plasma-framework, kde-workspace, libnm-qt and plasma-nm</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(d94adcf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114336/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic