'Re: Review Request 114336: Install all includes in a KF5 dir'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 114336: Install all includes in a KF5 dir
From:       "Johannes Huber" <johu () gentoo ! org>
Date:       2013-12-06 16:07:49
Message-ID: 20131206160749.10209.96248 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114336/#review45275
-----------------------------------------------------------

How about to make it lowercase?

- Johannes Huber

On Dec. 6, 2013, 5 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114336/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 5 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Install all includes in a KF5 dir. This is the first step to implement the header \
> policy discussed on kde-frameworks-devel. 
> 
> Diffs
> -----
> 
> kde-modules/KDEInstallDirs.cmake d94adcf 
> 
> Diff: http://git.reviewboard.kde.org/r/114336/diff/
> 
> 
> Testing
> -------
> 
> Removed install dir, then rebuilt kdelibs, kactivities, kde-runtime, \
> plasma-framework, kde-workspace, libnm-qt and plasma-nm 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114336/">http://git.reviewboard.kde.org/r/114336/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about to make it \
lowercase?</pre>  <br />

<p>- Johannes Huber</p>

<br />
<p>On December 6th, 2013, 5 p.m. CET, Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Stephen Kelly.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated Dec. 6, 2013, 5 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Install all includes in a KF5 dir. This is the first step to implement \
the header policy discussed on kde-frameworks-devel.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed install dir, then rebuilt kdelibs, kactivities, kde-runtime, \
plasma-framework, kde-workspace, libnm-qt and plasma-nm</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(d94adcf)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114336/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 