[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 114200: Add include for klocalizedstring in klocale.h
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2013-12-01 14:34:18
Message-ID: 20131201143418.30523.19990 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 29, 2013, 12:28 p.m., Albert Astals Cid wrote:
> > No, in KDE4 times, you got KLocalizedString though klocalizedstring.h, if people \
> > is including KLocale just for KLocalizedString that's "wrong" and i think adding \
> > this include is doing people a dis-service by maing think they depend on a tier4 \
> > framework when maybe they don't.
>
> Martin Gräßlin wrote:
> Than it's for code from kde3 times or older. The idea is to make porting easier. I \
> think everybody wants to get rid of kde4support and everybody needs to have \
> kde4support in the first step. As an example I'm just porting ksysguard. It nowhere \
> included klocalizedstring. Everywhere it was klocale, but nothing of klocale was \
> used.
> It's not possible to just do a replace of klocale by klocalizedstring in the \
> porting scripts as it's possible that the source file uses KLocale. It's a compile, \
> error, fix, compile game.
I agree with Martin.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114200/#review44796
-----------------------------------------------------------
On Nov. 29, 2013, 12:22 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114200/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2013, 12:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> One of the most often porting error I get is the lack of the KLocalizedString \
> include. In KDE4 times this was through klocale. So most files have an include to \
> klocale, but it is not used at all.
> By adding this include to klocale.h we can significantly decrease the initial \
> "get-it-compile-pain".
>
> Diffs
> -----
>
> tier4/kde4support/src/kdecore/klocale.h 1c446fe
>
> Diff: http://git.reviewboard.kde.org/r/114200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114200/">http://git.reviewboard.kde.org/r/114200/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 29th, 2013, 12:28 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No, in KDE4 times, you got KLocalizedString though klocalizedstring.h, \
if people is including KLocale just for KLocalizedString that's "wrong" \
and i think adding this include is doing people a dis-service by maing think they \
depend on a tier4 framework when maybe they don't.</pre> </blockquote>
<p>On November 29th, 2013, 12:37 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Than it's for code \
from kde3 times or older. The idea is to make porting easier. I think everybody wants \
to get rid of kde4support and everybody needs to have kde4support in the first step. \
As an example I'm just porting ksysguard. It nowhere included klocalizedstring. \
Everywhere it was klocale, but nothing of klocale was used.
It's not possible to just do a replace of klocale by klocalizedstring in the \
porting scripts as it's possible that the source file uses KLocale. It's a \
compile, error, fix, compile game.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with \
Martin.</pre> <br />
<p>- Stephen</p>
<br />
<p>On November 29th, 2013, 12:22 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2013, 12:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One of the most often porting error I get is the lack of the \
KLocalizedString include. In KDE4 times this was through klocale. So most files have \
an include to klocale, but it is not used at all.
By adding this include to klocale.h we can significantly decrease the initial \
"get-it-compile-pain".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier4/kde4support/src/kdecore/klocale.h <span style="color: \
grey">(1c446fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114200/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic