[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Superbuild in kdelibs
From:       Aurélien_Gâteau <agateau () kde ! org>
Date:       2013-11-28 15:02:10
Message-ID: 2217041.VAANDcE3u4 () trinity
[Download RAW message or body]

Le jeudi 28 novembre 2013 08:21:13 Aurélien Gâteau a écrit :
> Le jeudi 28 novembre 2013 19:58:38 Ben Cooksley a écrit :
> > On Thu, Nov 28, 2013 at 9:10 AM, Aurélien Gâteau <agateau@kde.org> wrote:
> > > Le jeudi 28 novembre 2013 07:41:19 Ben Cooksley a écrit :
> > > > On Nov 28, 2013 7:26 AM, "Aurélien Gâteau" <agateau@kde.org> wrote:
> > > > > Le mercredi 27 novembre 2013 10:16:57 Ben Cooksley a écrit :
> > > > > > Hi,
> > > > > > 
> > > > > > > I just disabled it, so that you can give it a try. Can you
> > > > > > > modify
> > > > 
> > > > kdelibs
> > > > 
> > > > > > > job
> > > > > > > definition so that cmake is called with -DSUPERBUILD=ON and
> > > > > > > "make
> > > > 
> > > > sb_all"
> > > > 
> > > > > > > is
> > > > > > > called first, then "make"?
> > > > > > 
> > > > > > That has now been done in 6a67a97e79f1c0251bf0038e8ecd46dbe59cae72
> > > > > > to
> > > > > > sysadmin/build-kde-org.
> > > > > > Unfortunately the build failed.
> > > > > 
> > > > > So I spent my day on that failure and build.kde.org is still red.
> > > > > The
> > > > 
> > > > failure
> > > > 
> > > > > is caused by meinproc5 not finding the kdex.dtd file. It should be
> > > 
> > > fixed
> > > 
> > > > by
> > > > 
> > > > > defining the XDG_DATA_DIRS variable to
> > > > > "$CMAKE_INSTALL_PREFIX/share/"
> > > 
> > > or
> > > 
> > > > > whatever dir where meinproc can find
> > > > 
> > > > "ksgmltools2/customization/dtd/kdex.dtd",
> > > > 
> > > > > installed by kdoctools (Ben, can you look into this?)
> > > > 
> > > > That is not possible I'm afraid - we have to keep the install prefix
> > > > out
> > > 
> > > of
> > > 
> > > > cmake_prefix_paths and other env variables otherwise fresh builds
> > > > would
> > > 
> > > be
> > > 
> > > > contaminated by prior runs.
> > > 
> > > Any framework which depends on kdoctools needs the binaries and files
> > > installed by kdoctools, so we need a way to do this. It used to be OK
> > > not
> > > do
> > > so this because kdoctools was used in "bootstrap" mode: it used files
> > > from
> > > kdelibs, but that is not applicable when building in standalone mode.
> > > 
> > > The situation is similar to, say, kde-baseapps or kdepim needing
> > > kdoctools:
> > > how is Jenkins set up so that they can make use of kdoctools?
> > 
> > This is done through generate_environment() of tools/kdecilib.py.
> > Every project has a set of dependencies, which the scripts will examine
> > and
> > set environment variables for appropriately to ensure they are available.
> > This covers path, cmake_prefix_path, xdg_data_dirs, etc.
> > 
> > The problem in this case is because kdelibs cannot depend on itself -
> > Superbuild needs to handle that. Once the frameworks have split they will
> > be able to declare their dependencies against each other through the usual
> > mechanism (so it will "just work"). This is how it works for everything
> > else at the moment.
> 
> OK, I am going to look into modifying kdoctools "bootstrap" mode to work
> with superbuild.

After much wrestling with that, I cannot find any way to get superbuild to 
work on build.kde.org, because of the use of DESTDIR. Someone with enough 
karma should apply attached patch on build-kde-org repository to disable it 
and make Jenkins useful again.

It's not too bad anyway since this won't be a problem anymore when 
repositories are split. Meanwhile, I am going to continue running my daily 
script to build kdelibs with superbuild together with the rest of plasma2 in 
order to catch failures.

Aurélien
["0001-Revert-Build-kdelibs-frameworks-with-Superbuild.patch" (0001-Revert-Build-kdelibs-frameworks-with-Superbuild.patch)]

From 17f2086028ff1921bfa913600ff9b432c93c6beb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aurélien Gâteau?= <agateau@kde.org>
Date: Thu, 28 Nov 2013 14:52:43 +0100
Subject: [PATCH] Revert "Build kdelibs[frameworks] with Superbuild"

It looks like it is impossible to build with superbuild and DESTDIR enabled, so
let's disable this and get kdelibs on build.kde.org useful again.

This reverts commit 6a67a97e79f1c0251bf0038e8ecd46dbe59cae72.
---
 config/build/kdelibs/qt5.cfg | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/config/build/kdelibs/qt5.cfg b/config/build/kdelibs/qt5.cfg
index 99d99d4..be14f4a 100644
--- a/config/build/kdelibs/qt5.cfg
+++ b/config/build/kdelibs/qt5.cfg
@@ -1,7 +1,3 @@
 [DEFAULT]
-configureExtraArgs=-DECMATEST_BASEDIR=%(scriptsLocation)s/ecma262 -DSUPERBUILD=ON
 kbuildsycoca4Executable=kbuildsycoca5
 kdeinitExecutable=kdeinit5
-
-[Build]
-postConfigureCommand=%(makeExecutable)s sb_all -l {loadLevel} -j {jobCount}
--
1.8.3.2



_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[prev in list] [next in list] [prev in thread] [next in thread]