'Re: Review Request 113631: Allow compiling kwindowsystem on Windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 113631: Allow compiling kwindowsystem on Windows
From:       "Alexander Richardson" <arichardson.kde () googlemail ! com>
Date:       2013-11-10 15:46:26
Message-ID: 20131110154626.1864.99566 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113631/
-----------------------------------------------------------

(Updated Nov. 10, 2013, 3:46 p.m.)

Review request for KDE Frameworks, Patrick Spendrin and Patrick von Reth.

Changes
-------

Adding the Gang of the Patricks to this review, let's hope they'll pay attention and help us. :-)

Repository: kdelibs

Description
-------

Allow compiling kwindowsystem on Windows

Diffs
-----

  tier1/CMakeLists.txt 277b3f0 
  tier1/kwindowsystem/CMakeLists.txt dc8fcae 
  tier1/kwindowsystem/src/CMakeLists.txt d9d141e 
  tier1/kwindowsystem/src/kkeyserver_win.h 6328f41 
  tier1/kwindowsystem/src/kstartupinfo.h 39c2935 
  tier1/kwindowsystem/src/kstartupinfo.cpp 402cc97 
  tier1/kwindowsystem/src/kwindowinfo_win.cpp d392fe9 
  tier1/kwindowsystem/src/kwindowsystem.h 0c6a930 
  tier1/kwindowsystem/src/kwindowsystem_win.cpp 23a6616 

Diff: http://git.reviewboard.kde.org/r/113631/diff/

Testing
-------

Compiles (Windows 7, VS 2012 x64)

Thanks,

Alexander Richardson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113631/">http://git.reviewboard.kde.org/r/113631/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Patrick Spendrin and Patrick von Reth.</div>
<div>By Alexander Richardson.</div>

<p style="color: grey;"><i>Updated Nov. 10, 2013, 3:46 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding the Gang of the Patricks to this review, let&#39;s hope \
they&#39;ll pay attention and help us. :-)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allow compiling kwindowsystem on Windows</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles (Windows 7, VS 2012 x64)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tier1/CMakeLists.txt <span style="color: grey">(277b3f0)</span></li>

 <li>tier1/kwindowsystem/CMakeLists.txt <span style="color: \
grey">(dc8fcae)</span></li>

 <li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: \
grey">(d9d141e)</span></li>

 <li>tier1/kwindowsystem/src/kkeyserver_win.h <span style="color: \
grey">(6328f41)</span></li>

 <li>tier1/kwindowsystem/src/kstartupinfo.h <span style="color: \
grey">(39c2935)</span></li>

 <li>tier1/kwindowsystem/src/kstartupinfo.cpp <span style="color: \
grey">(402cc97)</span></li>

 <li>tier1/kwindowsystem/src/kwindowinfo_win.cpp <span style="color: \
grey">(d392fe9)</span></li>

 <li>tier1/kwindowsystem/src/kwindowsystem.h <span style="color: \
grey">(0c6a930)</span></li>

 <li>tier1/kwindowsystem/src/kwindowsystem_win.cpp <span style="color: \
grey">(23a6616)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113631/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 