[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: RFC Rules for installation of header files
From:       Aurélien_Gâteau <agateau () kde ! org>
Date:       2013-11-07 10:25:33
Message-ID: 35232.109.13.158.252.1383819933.squirrel () webmail ! tuffmail ! net
[Download RAW message or body]

> On 06/11/13 13:52, Aur=E9lien G=E2teau wrote:
>> ## Most likely needed for SC
>>
>> Those headers were already there in KDE4.
>>
>> - conversion_check.h
>> - fixx11h.h
>> - kgenericfactory.tcc
>> - netwm_def.h
>> - netwm.h
>> - predicateproperties.h
>> - threadweaver installs headers as {lowercase}/{CamelCase}.h, instead of
>>   {lowercase}/{lowercase}.h
>> - KDE/kdbgstream
>> - KDE/kndbgstream
>> - KDE/NET
>> - KDE/NETRootInfo
>> - KDE/NETWinInfo
>> - KDE/OrgKdeKDirNotifyInterface
>> - KDE/PtyProcess: this one comes from kdesu, but there is also
>>   KPtyProcess (from kpty). That is potentially confusing.
>> - KDE/SshProcess
>> - KDE/StubProcess
>> - KDE/SuProcess
>> - KDE/ThumbCreator
>> - khtml installs CamelCase headers in KDE/khtml, instead of KDE/KHTML.
>
> One option would be to create/generate compatibility headers that
> contained #warning directives telling people to update their #includes
> (at least for the headers that do not just contain deprecated code,
> like predicateproperties.h).  That would allow us to ditch them at KF6
> time.

Makes sense.
>
> We might also be willing to break SC for those headers that are not
> very commonly used (conversion_check.h, for example, appears to be
> internal API that is only installed for the benefit of inline code).

Indeed, in the case of conversion_check.h: it is installed because
kconfiggroup.h includes it. Might be worth renaming it to
kconfiggroup_internal.h, or just inline its content in kconfiggroup.h
itself (it's only 120 lines, including license header).

Aur=E9lien


_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]