'Re: Review Request 113497: Install kiofilewidgets_export.h in /kio'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 113497: Install kiofilewidgets_export.h in /kio
From:       "Sune Vuorela" <kde () pusling ! com>
Date:       2013-10-29 12:55:56
Message-ID: 20131029125556.14620.77594 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113497/#review42629
-----------------------------------------------------------

Ship it!

Looks right to me. if correct test ing is done, shipit.

- Sune Vuorela

On Oct. 29, 2013, 12:24 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113497/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 12:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Install kiofilewidgets_export.h in /kio
> 
> Many files in there do #include <kio/kiofilewidgets_export.h>
> 
> This fixes build of kde-workspace.
> 
> 
> Diffs
> -----
> 
>   staging/kio/src/filewidgets/CMakeLists.txt fee8bed 
> 
> Diff: http://git.reviewboard.kde.org/r/113497/diff/
> 
> 
> Testing
> -------
> 
> kdelibs and kde-workspace build.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113497/">http://git.reviewboard.kde.org/r/113497/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks right to me. if \
correct test ing is done, shipit.</pre>  <br />

<p>- Sune Vuorela</p>

<br />
<p>On October 29th, 2013, 12:24 p.m. UTC, Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated Oct. 29, 2013, 12:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Install kiofilewidgets_export.h in /kio

Many files in there do #include &lt;kio/kiofilewidgets_export.h&gt;

This fixes build of kde-workspace.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdelibs and kde-workspace build.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>staging/kio/src/filewidgets/CMakeLists.txt <span style="color: \
grey">(fee8bed)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113497/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 