[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 113373: Enable C++11 support by default.
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2013-10-24 17:40:21
Message-ID: 20131024174021.19586.42227 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote:
> > As far as I know, only threadweaver and karchive will be released in December. \
> > The rest of the frameworks won't be released until summer.
> > By summer, CMake 3.0.0 will most likely be out.
>
> Volker Krause wrote:
> while the CMake 3 solution is obviously much nicer, what are our alternatives until \
> then? The current solution is adding -std=c++0x without proper compiler checks \
> ad-hoc where needed, I think that's far worse than this change. Also, it wont \
> detect incompatibilities with C++11 in currently C++98-only code paths. And changes \
> here are needed anyway, since -ansi effectively prevents you from enabling C++11 \
> (which also suggests ICC hasn't been tested in quite a while).
>
> Ivan Čukić wrote:
> +1
>
> Stephen Kelly wrote:
> Fair enough.
>
> I don't recommend releasing ecm with this though.
>
> I don't see any reason to release ecm when releasing KArchive and Threadweaver. I \
> recommend just copying needed files into the first release of those instead.
> Alexander Neundorf wrote:
> I.e. both will have copies of ECMSetupVersion.cmake, ECMVersionHeader.h.in, \
> KDEInstallDirs.cmake, KDECompilerSettings.cmake and KDECMakeSettings.cmake ? This \
> is just so much against what was originally, at least my, idea of e-c-m: make cmake \
> stuff we have in KDE, but which can be useful also in other projects, easier and \
> quicker available to others (instead of not being able to release it when the first \
> frameworks are released). But I don't object, it's your decision.
>
It's not my decision either. It's just a recommendation.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113373/#review42130
-----------------------------------------------------------
On Oct. 21, 2013, 6:51 p.m., Volker Krause wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113373/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 6:51 p.m.)
>
>
> Review request for Extra Cmake Modules, KDE Frameworks and Stephen Kelly.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Enable C++11 support by default.
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake b745ec3c52fe66b3cfb89a334c99a5ea8ef71d4d
>
> Diff: http://git.reviewboard.kde.org/r/113373/diff/
>
>
> Testing
> -------
>
> Compiles, all required fixes have been integrated into the frameworks branch by now \
> (at least for the subset I have the required dependencies for).
>
> Thanks,
>
> Volker Krause
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113373/">http://git.reviewboard.kde.org/r/113373/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 21st, 2013, 8:06 p.m. UTC, <b>Stephen \
Kelly</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As far as I know, only threadweaver and karchive will be released in \
December. The rest of the frameworks won't be released until summer.
By summer, CMake 3.0.0 will most likely be out.</pre>
</blockquote>
<p>On October 23rd, 2013, 12:44 p.m. UTC, <b>Volker Krause</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">while the CMake 3 \
solution is obviously much nicer, what are our alternatives until then? The current \
solution is adding -std=c++0x without proper compiler checks ad-hoc where needed, I \
think that's far worse than this change. Also, it wont detect incompatibilities \
with C++11 in currently C++98-only code paths. And changes here are needed anyway, \
since -ansi effectively prevents you from enabling C++11 (which also suggests ICC \
hasn't been tested in quite a while). </pre>
</blockquote>
<p>On October 23rd, 2013, 4:43 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+1</pre> </blockquote>
<p>On October 24th, 2013, 1:46 p.m. UTC, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fair enough.
I don't recommend releasing ecm with this though.
I don't see any reason to release ecm when releasing KArchive and Threadweaver. I \
recommend just copying needed files into the first release of those instead.</pre> \
</blockquote>
<p>On October 24th, 2013, 4:58 p.m. UTC, <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I.e. both will have \
copies of ECMSetupVersion.cmake, ECMVersionHeader.h.in, KDEInstallDirs.cmake, \
KDECompilerSettings.cmake and KDECMakeSettings.cmake ? This is just so much against \
what was originally, at least my, idea of e-c-m: make cmake stuff we have in KDE, but \
which can be useful also in other projects, easier and quicker available to others \
(instead of not being able to release it when the first frameworks are released). But \
I don't object, it's your decision. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not my decision \
either. It's just a recommendation.</pre> <br />
<p>- Stephen</p>
<br />
<p>On October 21st, 2013, 6:51 p.m. UTC, Volker Krause wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Extra Cmake Modules, KDE Frameworks and Stephen Kelly.</div>
<div>By Volker Krause.</div>
<p style="color: grey;"><i>Updated Oct. 21, 2013, 6:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Enable C++11 support by default.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, all required fixes have been integrated into the frameworks \
branch by now (at least for the subset I have the required dependencies for).</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(b745ec3c52fe66b3cfb89a334c99a5ea8ef71d4d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113373/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic