[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 113298: KDirWatch code style: cleanup whitespace.
From: Nicolás_Alvarez <nicolas.alvarez () gmail ! com>
Date: 2013-10-17 19:52:58
Message-ID: 20131017195258.28427.47760 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote:
> > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp, line 1225
> > <http://git.reviewboard.kde.org/r/113298/diff/3/?file=202348#file202348line1225>
> >
> > I think this could be better as uncommenting the variable and using Q_UNUSED (and \
> > moving the * to the right too), but that's minor
Sure, I can do that.
> On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote:
> > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 199
> > <http://git.reviewboard.kde.org/r/113298/diff/3/?file=202349#file202349line199>
> >
> > why did you choose "_path" instead of just "path"?
Because that's what the definition has in the .cpp:
KDirWatchPrivate::Entry* KDirWatchPrivate::entry(const QString &_path)
I could change them all to path, I don't know why it has an underscore. But that's \
for a separate commit.
- Nicolás
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/#review41907
-----------------------------------------------------------
On Oct. 17, 2013, 4:05 p.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113298/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 4:05 p.m.)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> KDirWatch code style: cleanup whitespace.
>
> The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and \
> alignment, including a few tabs(!). This is a full cleanup of it.
> I appreciate any feedback; if I "fixed" something that didn't need fixing, or if \
> you see more whitespace errors that I didn't fix, or if I should push this to \
> master too, or if I should leave the damn thing alone and discard the review :)
> This file is also lacking braces for single-line conditionals and loops; I'll fix \
> that in a separate commit for easier reviewing. It's also mixing 2-space and \
> 4-space indentations, but changing everything to 4 spaces (as the kdelibs coding \
> style says) seemed too intrusive. Perhaps I should change the few 4-space \
> indentations into 2-space for consistency?
>
> Diffs
> -----
>
> tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d \
> tier1/kcoreaddons/src/lib/io/kdirwatch.cpp \
> e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a tier1/kcoreaddons/src/lib/io/kdirwatch.h \
> 7f6ca8ce83426c81a6336514c247aa9d115ec59e
> Diff: http://git.reviewboard.kde.org/r/113298/diff/
>
>
> Testing
> -------
>
> Still compiles :)
>
>
> Thanks,
>
> Nicolás Alvarez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113298/">http://git.reviewboard.kde.org/r/113298/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 17th, 2013, 4:27 p.m. ART, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/3/?file=202348#file202348line1225" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KDirWatchPrivate::resetList( KDirWatch* /*instance*/, bool skippedToo )</pre></td> \
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KDirWatchPrivate::resetList(KDirWatch* /*instance*/, bool skippedToo)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1223</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> \
<span class="n">KDirWatchPrivate</span><span class="o">::</span><span \
class="n">resetList</span><span class="p">(</span> <span \
class="n">KDirWatch</span><span class="o">*</span> <span \
class="cm">/*instance*/</span><span class="p">,</span> <span class="kt">bool</span> \
<span class="n">skippedToo</span> <span class="p">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1223</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">KDirWatchPrivate</span><span \
class="o">::</span><span class="n">resetList</span><span class="p">(</span><span \
class="n">KDirWatch</span><span class="o">*</span> <span \
class="cm">/*instance*/</span><span class="p">,</span> <span class="kt">bool</span> \
<span class="n">skippedToo</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this could be \
better as uncommenting the variable and using Q_UNUSED (and moving the * to the right \
too), but that's minor</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, I can \
do that.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 17th, 2013, 4:27 p.m. ART, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/3/?file=202349#file202349line199" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch_p.h</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">199</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Entry</span><span class="o">*</span> <span class="nf">entry</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span><span \
class="o"><span class="hl">&</span></span><span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">199</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Entry</span><span class="o">*</span> <span class="nf">entry</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o"><span class="hl">&</span></span><span class="n"><span \
class="hl">_path</span></span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why did you choose \
"_path" instead of just "path"?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because \
that's what the definition has in the .cpp: KDirWatchPrivate::Entry* \
KDirWatchPrivate::entry(const QString &_path)
I could change them all to path, I don't know why it has an underscore. But \
that's for a separate commit.</pre> <br />
<p>- Nicolás</p>
<br />
<p>On October 17th, 2013, 4:05 p.m. ART, Nicolás Alvarez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Nicolás Alvarez.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2013, 4:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KDirWatch code style: cleanup whitespace.
The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and \
alignment, including a few tabs(!). This is a full cleanup of it.
I appreciate any feedback; if I "fixed" something that didn't need \
fixing, or if you see more whitespace errors that I didn't fix, or if I should \
push this to master too, or if I should leave the damn thing alone and discard the \
review :)
This file is also lacking braces for single-line conditionals and loops; I'll fix \
that in a separate commit for easier reviewing. It's also mixing 2-space and \
4-space indentations, but changing everything to 4 spaces (as the kdelibs coding \
style says) seemed too intrusive. Perhaps I should change the few 4-space \
indentations into 2-space for consistency?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still compiles :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/src/lib/io/kdirwatch_p.h <span style="color: \
grey">(442d6497b704c179adc13dbb25e450554d31554d)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <span style="color: \
grey">(e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.h <span style="color: \
grey">(7f6ca8ce83426c81a6336514c247aa9d115ec59e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113298/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic