[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 113267: Install kglobalshortcutinfo_p.h
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-10-17 5:37:28
Message-ID: 20131017053728.5893.78620 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 17, 2013, 6:36 a.m., David Edmundson wrote:
> > Clients using this can build a header file from the installed XML service file \
> > using qt5_add_dbus_interface.
try it! It doesn't work. That's the whole point why I opened the review request. The \
build fails because it needs to include the private header.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113267/#review41855
-----------------------------------------------------------
On Oct. 16, 2013, 3:56 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113267/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 3:56 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> kglobalshortcutinfo_p.h used to be installed in kde4 times and it is needed to \
> generate the DBus interface from org.kde.KGlobalAccel.xml.
>
> Diffs
> -----
>
> tier3/xmlgui/src/CMakeLists.txt f5c8fa1
>
> Diff: http://git.reviewboard.kde.org/r/113267/diff/
>
>
> Testing
> -------
>
> See http://build.kde.org/job/kde-workspace_master_qt5/1362/consoleFull
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113267/">http://git.reviewboard.kde.org/r/113267/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 17th, 2013, 6:36 a.m. CEST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Clients using this can build a header file from the installed XML \
service file using qt5_add_dbus_interface. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">try it! It doesn't \
work. That's the whole point why I opened the review request. The build fails \
because it needs to include the private header.</pre> <br />
<p>- Martin</p>
<br />
<p>On October 16th, 2013, 3:56 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2013, 3:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kglobalshortcutinfo_p.h used to be installed in kde4 times and it is \
needed to generate the DBus interface from org.kde.KGlobalAccel.xml.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">See http://build.kde.org/job/kde-workspace_master_qt5/1362/consoleFull</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/xmlgui/src/CMakeLists.txt <span style="color: grey">(f5c8fa1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113267/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic