[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new sig
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2013-10-14 13:04:02
Message-ID: 20131014130402.12755.7458 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 14, 2013, 12:52 p.m., David Faure wrote:
> > tier1/kcoreaddons/src/lib/jobs/kjob.h, line 372
> > <http://git.reviewboard.kde.org/r/113205/diff/3/?file=201072#file201072line372>
> >
> > I wonder if the Qt/kdelibs coding style has something about indentation of \
> > pre-processor directives, I would have expected this to be left-aligned on column \
> > 0.
Do you want me to left align it for the commit? Both are OK with me, this simply \
looked better :)
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41714
-----------------------------------------------------------
On Oct. 14, 2013, 12:46 p.m., Mark Gaiser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113205/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2013, 12:46 p.m.)
>
>
> Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> The new signal/slot connection:
> connect(job, &KJob::result,...
>
> does't like result to be private and throws an compile error:
> error: 'void KJob::result(KJob*)' is private
>
> Making it public resolves the issue and makes this slot usable in the new syntax. \
> In my case i wanted to use the new syntax and directly use a lambda as slot. Which \
> isn't possible on this signal if it isn't public.
>
> Diffs
> -----
>
> tier1/kcoreaddons/src/lib/jobs/kjob.h d663530
> tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f
>
> Diff: http://git.reviewboard.kde.org/r/113205/diff/
>
>
> Testing
> -------
>
> Works just fine.
>
>
> Thanks,
>
> Mark Gaiser
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113205/">http://git.reviewboard.kde.org/r/113205/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 14th, 2013, 12:52 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113205/diff/3/?file=201072#file201072line372" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/jobs/kjob.h</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">private: // don't tell moc, doxygen or kdevelop, but those signals are in fact \
private</pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">369</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="err">#</span><span class="k">if</span> <span class="o">!</span><span \
class="n">defined</span><span class="p">(</span><span \
class="n">DOXYGEN_SHOULD_SKIP_THIS</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder if the \
Qt/kdelibs coding style has something about indentation of pre-processor directives, \
I would have expected this to be left-aligned on column 0.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you want \
me to left align it for the commit? Both are OK with me, this simply looked better \
:)</pre> <br />
<p>- Mark</p>
<br />
<p>On October 14th, 2013, 12:46 p.m. UTC, Mark Gaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2013, 12:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The new signal/slot connection: connect(job, &KJob::result,...
does't like result to be private and throws an compile error:
error: 'void KJob::result(KJob*)' is private
Making it public resolves the issue and makes this slot usable in the new syntax. In \
my case i wanted to use the new syntax and directly use a lambda as slot. Which \
isn't possible on this signal if it isn't public.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works just fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/src/lib/jobs/kjob.h <span style="color: \
grey">(d663530)</span></li>
<li>tier1/kcoreaddons/src/lib/jobs/kjob.cpp <span style="color: \
grey">(f99a99f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113205/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic