'Re: Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt
From:       "Stephen Kelly" <steveire () gmail ! com>
Date:       2013-10-14 10:48:12
Message-ID: 20131014104812.18994.68648 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113238/#review41699
-----------------------------------------------------------

Ship it!

Also consider (separately) removing the _LIBRARIES variables from the Config files, \
so that there is one consistent way to use a KF5 framework (KF5::Solid, not \
Solid_LIBRARIES). kde-workspace and plasma currently mix both and should be \
normalized first, obviously.

- Stephen Kelly

On Oct. 14, 2013, 10:43 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113238/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 10:43 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Remove set _LIBRARIES calls in root CMakeLists.txt
> 
> Update all other modules to use KF5::LibraryName
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt 17c3090 
> kded/CMakeLists.txt 7532687 
> kdewidgets/CMakeLists.txt 885091e 
> khtml/src/CMakeLists.txt 5e00c8c 
> khtml/src/kmultipart/CMakeLists.txt 3fc6982 
> kio/misc/kpac/CMakeLists.txt 897de8e 
> staging/kio/src/core/CMakeLists.txt 5d75fc9 
> staging/kio/src/filewidgets/CMakeLists.txt 3790250 
> 
> Diff: http://git.reviewboard.kde.org/r/113238/diff/
> 
> 
> Testing
> -------
> 
> compiled
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113238/">http://git.reviewboard.kde.org/r/113238/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also consider \
(separately) removing the _LIBRARIES variables from the Config files, so that there \
is one consistent way to use a KF5 framework (KF5::Solid, not Solid_LIBRARIES). \
kde-workspace and plasma currently mix both and should be normalized first, \
obviously.</pre>  <br />

<p>- Stephen Kelly</p>

<br />
<p>On October 14th, 2013, 10:43 a.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Oct. 14, 2013, 10:43 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove set _LIBRARIES calls in root CMakeLists.txt

Update all other modules to use KF5::LibraryName

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(17c3090)</span></li>

 <li>kded/CMakeLists.txt <span style="color: grey">(7532687)</span></li>

 <li>kdewidgets/CMakeLists.txt <span style="color: grey">(885091e)</span></li>

 <li>khtml/src/CMakeLists.txt <span style="color: grey">(5e00c8c)</span></li>

 <li>khtml/src/kmultipart/CMakeLists.txt <span style="color: \
grey">(3fc6982)</span></li>

 <li>kio/misc/kpac/CMakeLists.txt <span style="color: grey">(897de8e)</span></li>

 <li>staging/kio/src/core/CMakeLists.txt <span style="color: \
grey">(5d75fc9)</span></li>

 <li>staging/kio/src/filewidgets/CMakeLists.txt <span style="color: \
grey">(3790250)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113238/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 