'Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.
From:       "David Faure" <faure () kde ! org>
Date:       2013-10-12 8:33:37
Message-ID: 20131012083337.11681.80152 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113196/#review41573
-----------------------------------------------------------

Ship it!

So time_t does exist on Windows? Very interesting, I really thought it didn't.

Proving again that blind-porting to Windows is a bad idea :)
Thank you for doing the real thing i.e. actually trying it out on Windows.

- David Faure

On Oct. 11, 2013, 5:25 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113196/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2013, 5:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kdirwatch: include correct header for time_t and ino_t.
> 
> We were including sys/time.h and sys/param.h, but Windows doesn't have
> them, and POSIX says those types are defined in sys/types.h.
> 
> This doesn't fix the build on Windows, but it's a step.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 77c7d6d1f83f0c984043ed1c7e3a83a2e824d0c7 
> 
> Diff: http://git.reviewboard.kde.org/r/113196/diff/
> 
> 
> Testing
> -------
> 
> Still builds and passes tests on Linux/gcc.
> 
> Still fails to build on Windows/MSVC2010 but not for this reason :)
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113196/">http://git.reviewboard.kde.org/r/113196/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So time_t does exist on \
Windows? Very interesting, I really thought it didn&#39;t.

Proving again that blind-porting to Windows is a bad idea :)
Thank you for doing the real thing i.e. actually trying it out on Windows.</pre>
 <br />

<p>- David Faure</p>

<br />
<p>On October 11th, 2013, 5:25 p.m. UTC, Nicolás Alvarez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Nicolás Alvarez.</div>

<p style="color: grey;"><i>Updated Oct. 11, 2013, 5:25 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdirwatch: include correct header for time_t and ino_t.

We were including sys/time.h and sys/param.h, but Windows doesn&#39;t have
them, and POSIX says those types are defined in sys/types.h.

This doesn&#39;t fix the build on Windows, but it&#39;s a step.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still builds and passes tests on Linux/gcc.

Still fails to build on Windows/MSVC2010 but not for this reason :)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tier1/kcoreaddons/src/lib/io/kdirwatch_p.h <span style="color: \
grey">(77c7d6d1f83f0c984043ed1c7e3a83a2e824d0c7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113196/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 