[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 112880: Added KColorSchemeToken class.
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2013-10-09 17:14:01
Message-ID: 20131009171401.31169.51778 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 24, 2013, 6:55 a.m., Kevin Ottens wrote:
> > I'm not sure we can let that in for kdelibs 4.x / kdeui... David? Any opinion?
> >
> > If we ignore that point for the moment, and think in terms of KF5, ATM it would \
> > go with KColorScheme in KConfigWidgets. I'm not quite sold on the "Token" name \
> > though. It comes from the fact that it attempts to be the QML API but provided as \
> > a C++ API, shouldn't it be in a declarative import plugin with no C++ API? That'd \
> > put less pressure on the class name.
I still don't like having that in kdeui... What about kdeclarative instead? Not sure \
the dependencies are acceptable for it though. I'd say let's land it there first and \
then we'll see.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40635
-----------------------------------------------------------
On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2013, 7:24 p.m.)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them \
> accessible from QML code.
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to \
> libkdegames, as it uses it to access KDE's color theme.
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames \
> mailinglists *
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt b439e04
> includes/CMakeLists.txt cdf0143
> includes/KColorSchemeToken PRE-CREATION
> kdeui/colors/kcolorscheme.h 17570fd
> kdeui/colors/kcolorscheme.cpp a6650ac
> kdeui/colors/kcolorschemetoken.h PRE-CREATION
> kdeui/colors/kcolorschemetoken.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
>
>
> Testing
> -------
>
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
>
>
> Thanks,
>
> Denis Kuplyakov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112880/">http://git.reviewboard.kde.org/r/112880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 24th, 2013, 6:55 a.m. UTC, <b>Kevin \
Ottens</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not sure we can let that in for kdelibs 4.x / kdeui... David? \
Any opinion?
If we ignore that point for the moment, and think in terms of KF5, ATM it would go \
with KColorScheme in KConfigWidgets. I'm not quite sold on the "Token" \
name though. It comes from the fact that it attempts to be the QML API but provided \
as a C++ API, shouldn't it be in a declarative import plugin with no C++ API? \
That'd put less pressure on the class name.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still don't like \
having that in kdeui... What about kdeclarative instead? Not sure the dependencies \
are acceptable for it though. I'd say let's land it there first and then \
we'll see.</pre> <br />
<p>- Kevin</p>
<br />
<p>On October 6th, 2013, 7:24 p.m. UTC, Denis Kuplyakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2013, 7:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It is wrapper to access KColorScheme's methods from QML code. Also \
added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from \
QML code.
As it will be accepted, QML-clone of KgPopupItem will be posted for review to \
libkdegames, as it uses it to access KDE's color theme.
More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames \
mailinglists *</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've tested it with KReversi's deniskup/gsoc2013/newdesign \
branch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(b439e04)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(cdf0143)</span></li>
<li>includes/KColorSchemeToken <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/colors/kcolorscheme.h <span style="color: grey">(17570fd)</span></li>
<li>kdeui/colors/kcolorscheme.cpp <span style="color: grey">(a6650ac)</span></li>
<li>kdeui/colors/kcolorschemetoken.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kdeui/colors/kcolorschemetoken.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112880/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic