[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 112932: Update superbuild to include all tiered libraries
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2013-09-25 17:18:14
Message-ID: 20130925171814.17368.65317 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote:
> > Looks good to me, not adding the shipit because I'm clueless about superbuild.
> >
> > Why do we need to specify the dependencies from superbuild? Shouldn't they depend \
> > on the Config.cmake files?
You mean after "DEPENDS" ?
Because the superbuild CMakeLists.txt has no information otherwise which sub-builds \
depend on which other sub-builds, so this information must be there to make sure e.g. \
tier1 libs are built before tier2 libs etc.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112932/#review40764
-----------------------------------------------------------
On Sept. 25, 2013, 12:54 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112932/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2013, 12:54 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
>
> Add missing find_packages to kunitconversion
>
> --
>
> Update superbuild to include all tiered libraries
>
> (separate commits)
>
> superbuild dependencies were taken from the relevant CMake.in files, which may or \
> may not be correct.
>
> Diffs
> -----
>
> tier3/kunitconversion/KUnitConversionConfig.cmake.in 7bbf71c
> superbuild/CMakeLists.txt 86e3389
>
> Diff: http://git.reviewboard.kde.org/r/112932/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112932/">http://git.reviewboard.kde.org/r/112932/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 25th, 2013, 2:03 p.m. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good to me, not adding the shipit because I'm clueless about \
superbuild.
Why do we need to specify the dependencies from superbuild? Shouldn't they depend \
on the Config.cmake files?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You mean after \
"DEPENDS" ? Because the superbuild CMakeLists.txt has no information \
otherwise which sub-builds depend on which other sub-builds, so this information must \
be there to make sure e.g. tier1 libs are built before tier2 libs etc. </pre>
<br />
<p>- Alexander</p>
<br />
<p>On September 25th, 2013, 12:54 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2013, 12:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Add missing find_packages to kunitconversion
--
Update superbuild to include all tiered libraries
(separate commits)
superbuild dependencies were taken from the relevant CMake.in files, which may or may \
not be correct. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/kunitconversion/KUnitConversionConfig.cmake.in <span style="color: \
grey">(7bbf71c)</span></li>
<li>superbuild/CMakeLists.txt <span style="color: grey">(86e3389)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112932/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic