[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 112556: Move itemviews to tier2
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2013-09-13 15:02:47
Message-ID: 20130913150247.9823.66435 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 5:02 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks.
Description
-------
In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the
if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within
kdelibs.
Diffs
-----
staging/CMakeLists.txt f0b6bf0
staging/itemviews/CMakeLists.txt f5c3c8d
staging/itemviews/ItemViewsConfig.cmake.in c10f49f
staging/itemviews/autotests/CMakeLists.txt
staging/itemviews/autotests/klistwidgetsearchlinetest.cpp
staging/itemviews/src/CMakeLists.txt
staging/itemviews/src/kcategorizedsortfilterproxymodel.h
staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp
staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h
staging/itemviews/src/kcategorizedview.h
staging/itemviews/src/kcategorizedview.cpp
staging/itemviews/src/kcategorizedview_p.h
staging/itemviews/src/kcategorydrawer.h
staging/itemviews/src/kcategorydrawer.cpp
staging/itemviews/src/kextendableitemdelegate.h
staging/itemviews/src/kextendableitemdelegate.cpp
staging/itemviews/src/kfilterproxysearchline.h
staging/itemviews/src/kfilterproxysearchline.cpp
staging/itemviews/src/klistwidgetsearchline.h
staging/itemviews/src/klistwidgetsearchline.cpp
staging/itemviews/src/ktreewidgetsearchline.h
staging/itemviews/src/ktreewidgetsearchline.cpp
staging/itemviews/src/kwidgetitemdelegate.h
staging/itemviews/src/kwidgetitemdelegate.cpp
staging/itemviews/src/kwidgetitemdelegate_p.h
staging/itemviews/src/kwidgetitemdelegatepool.cpp
staging/itemviews/src/kwidgetitemdelegatepool_p.h
staging/itemviews/tests/CMakeLists.txt
staging/itemviews/tests/kcategorizedviewtest.cpp
staging/itemviews/tests/ktreewidgetsearchlinetest.h
staging/itemviews/tests/ktreewidgetsearchlinetest.cpp
staging/itemviews/tests/kwidgetitemdelegatetest.cpp
tier2/CMakeLists.txt 62faacb
Diff: http://git.reviewboard.kde.org/r/112556/diff/
Testing
-------
Builds and passes tests when build from kdelibs and standalone.
Thanks,
Aurélien Gâteau
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112556/">http://git.reviewboard.kde.org/r/112556/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2013, 5:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the if \
(NOT kdelibs_SOURCE_DIR) test otherwise it would not build within kdelibs.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds and passes tests when build from kdelibs and standalone.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(f0b6bf0)</span></li>
<li>staging/itemviews/CMakeLists.txt <span style="color: grey">(f5c3c8d)</span></li>
<li>staging/itemviews/ItemViewsConfig.cmake.in <span style="color: \
grey">(c10f49f)</span></li>
<li>staging/itemviews/autotests/CMakeLists.txt <span style="color: \
grey">()</span></li>
<li>staging/itemviews/autotests/klistwidgetsearchlinetest.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kcategorizedview.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kcategorizedview.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kcategorizedview_p.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kcategorydrawer.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorydrawer.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kextendableitemdelegate.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kextendableitemdelegate.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kfilterproxysearchline.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kfilterproxysearchline.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/klistwidgetsearchline.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/klistwidgetsearchline.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/ktreewidgetsearchline.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/ktreewidgetsearchline.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate_p.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegatepool.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegatepool_p.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/itemviews/tests/kcategorizedviewtest.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/tests/ktreewidgetsearchlinetest.h <span style="color: \
grey">()</span></li>
<li>staging/itemviews/tests/ktreewidgetsearchlinetest.cpp <span style="color: \
grey">()</span></li>
<li>staging/itemviews/tests/kwidgetitemdelegatetest.cpp <span style="color: \
grey">()</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(62faacb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112556/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic