[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 109667: Make some KConfig classes return a bool when saving
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2013-06-22 12:42:59
Message-ID: 20130622124259.6448.93641 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/#review34870
-----------------------------------------------------------
i didn't check whether every virtual override is correct, but generally the patch looks correct.
tier2/kconfig/autotests/kconfigguitest.cpp
<http://git.reviewboard.kde.org/r/109667/#comment25551>
you should wrap the line as you change the code.
- Oswald Buddenhagen
On June 22, 2013, 9:31 a.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109667/
> -----------------------------------------------------------
>
> (Updated June 22, 2013, 9:31 a.m.)
>
>
> Review request for KDE Frameworks and Oswald Buddenhagen.
>
>
> Description
> -------
>
> If it can fail, i want to know it so i can tell my users
>
>
> Diffs
> -----
>
> KDE5PORTING.html ba67bdc
> tier2/kconfig/autotests/kconfig_compiler/test_signal.cpp.ref fc04701
> tier2/kconfig/autotests/kconfig_compiler/test_signal.h.ref f43f7dd
> tier2/kconfig/autotests/kconfigguitest.cpp e6b4c17
> tier2/kconfig/autotests/kconfigtest.h 17a5294
> tier2/kconfig/autotests/kconfigtest.cpp 00ffc2a
> tier2/kconfig/autotests/ksharedconfigtest.cpp 2bb612f
> tier2/kconfig/src/core/kconfig.h 597330f
> tier2/kconfig/src/core/kconfig.cpp d26f941
> tier2/kconfig/src/core/kconfigbase.h ce190f3
> tier2/kconfig/src/core/kconfiggroup.h ff63afa
> tier2/kconfig/src/core/kconfiggroup.cpp 53cac13
> tier2/kconfig/src/core/kcoreconfigskeleton.h 3e4971b
> tier2/kconfig/src/core/kcoreconfigskeleton.cpp c0ad044
> tier2/kconfig/src/kconfig_compiler/kconfig_compiler.cpp 47963a5
>
> Diff: http://git.reviewboard.kde.org/r/109667/diff/
>
>
> Testing
> -------
>
> New Unitttest passes
>
>
> Thanks,
>
> Albert Astals Cid
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109667/">http://git.reviewboard.kde.org/r/109667/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i didn't check \
whether every virtual override is correct, but generally the patch looks \
correct.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109667/diff/4/?file=165071#file165071line127" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier2/kconfig/autotests/kconfigguitest.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KConfigTest::testInvalid()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">127</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">sc3</span><span class="p">.</span><span class="n">writeEntry</span><span \
class="p">(</span> <span class="s">"badList"</span><span class="p">,</span> \
<span class="n">list</span> <span class="p">);</span> <span class="n">sc</span><span \
class="p">.</span><span class="n">sync</span><span class="p">();</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">127</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">sc3</span><span class="p">.</span><span class="n">writeEntry</span><span \
class="p">(</span> <span class="s">"badList"</span><span class="p">,</span> \
<span class="n">list</span> <span class="p">);</span> <span class="n"><span \
class="hl">QVERIFY</span></span><span class="p"><span class="hl">(</span></span><span \
class="n">sc</span><span class="p">.</span><span class="n">sync</span><span \
class="p">()<span class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you should \
wrap the line as you change the code.</pre> </div>
<br />
<p>- Oswald</p>
<br />
<p>On June 22nd, 2013, 9:31 a.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Oswald Buddenhagen.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated June 22, 2013, 9:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If it can fail, i want to know it so i can tell my users</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New Unitttest passes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(ba67bdc)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test_signal.cpp.ref <span style="color: \
grey">(fc04701)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test_signal.h.ref <span style="color: \
grey">(f43f7dd)</span></li>
<li>tier2/kconfig/autotests/kconfigguitest.cpp <span style="color: \
grey">(e6b4c17)</span></li>
<li>tier2/kconfig/autotests/kconfigtest.h <span style="color: \
grey">(17a5294)</span></li>
<li>tier2/kconfig/autotests/kconfigtest.cpp <span style="color: \
grey">(00ffc2a)</span></li>
<li>tier2/kconfig/autotests/ksharedconfigtest.cpp <span style="color: \
grey">(2bb612f)</span></li>
<li>tier2/kconfig/src/core/kconfig.h <span style="color: grey">(597330f)</span></li>
<li>tier2/kconfig/src/core/kconfig.cpp <span style="color: \
grey">(d26f941)</span></li>
<li>tier2/kconfig/src/core/kconfigbase.h <span style="color: \
grey">(ce190f3)</span></li>
<li>tier2/kconfig/src/core/kconfiggroup.h <span style="color: \
grey">(ff63afa)</span></li>
<li>tier2/kconfig/src/core/kconfiggroup.cpp <span style="color: \
grey">(53cac13)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.h <span style="color: \
grey">(3e4971b)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.cpp <span style="color: \
grey">(c0ad044)</span></li>
<li>tier2/kconfig/src/kconfig_compiler/kconfig_compiler.cpp <span style="color: \
grey">(47963a5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109667/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic