[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Review Request 110209: macro_add_file_dependencies -> set_property in tier2/kconfig
From: "George Goldberg" <grundleborg () googlemail ! com>
Date: 2013-04-26 21:02:41
Message-ID: 20130426210241.32667.31988 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110209/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Description
-------
macro_add_file_dependencies -> set_property
Change from macro_add_file_dependencies to set_property as advised by the
macro_add_file_dependencies code comments in current cmake git.
I was getting errors from cmake about macro_add_file_dependencies not being found, \
and when I located the file with it in, it said that it was deprecated anyway, and to \
replace with set_property.
Diffs
-----
tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt \
87c7caa433e2916bebd0cab55f0489a3461e8208
Diff: http://git.reviewboard.kde.org/r/110209/diff/
Testing
-------
Compiles fine now.
Thanks,
George Goldberg
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110209/">http://git.reviewboard.kde.org/r/110209/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By George Goldberg.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">macro_add_file_dependencies -> set_property
Change from macro_add_file_dependencies to set_property as advised by the
macro_add_file_dependencies code comments in current cmake git.
I was getting errors from cmake about macro_add_file_dependencies not being found, \
and when I located the file with it in, it said that it was deprecated anyway, and to \
replace with set_property.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles fine now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt <span style="color: \
grey">(87c7caa433e2916bebd0cab55f0489a3461e8208)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110209/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic