From kde-frameworks-devel Sun Mar 17 16:41:29 2013 From: "Rolf Eike Beer" Date: Sun, 17 Mar 2013 16:41:29 +0000 To: kde-frameworks-devel Subject: Re: Review Request 109549: port KRun away from KProcess Message-Id: <20130317164129.23205.41162 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=136354862119971 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8983173595285472773==" --===============8983173595285472773== Content-Type: multipart/alternative; boundary="===============6306853446643583513==" --===============6306853446643583513== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29391 ----------------------------------------------------------- kio/kio/krun.cpp Whitespacing around braces is inconsistent. kio/kio/krun.cpp Trailing whitespace - Rolf Eike Beer On March 17, 2013, 4:19 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109549/ > ----------------------------------------------------------- > > (Updated March 17, 2013, 4:19 p.m.) > > > Review request for KDE Frameworks, kdelibs and David Faure. > > > Description > ------- > > Port KRun to use QProcess instead of KProcess. > > Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory. > > > Diffs > ----- > > kio/kio/krun.cpp 76b7385 > kio/kio/krun_p.h 01abb69 > > Diff: http://git.reviewboard.kde.org/r/109549/diff/ > > > Testing > ------- > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============6306853446643583513== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/

kio/kio/krun.cpp (Diff revision 1) 
mode_t KRun::mode() const
 

    1772
    
        process->setWorkingDirectory(workingDirectory);

  


 





Whitespacing around braces is inconsistent.














 
  

   
    kio/kio/krun.cpp
    

     (Diff revision 1)

    
   
  

 

 
  


   
mode_t KRun::mode() const


  

 



 
 

 

  

    
    

    1773
    
    

  


 





Trailing whitespace









- Rolf Eike






On March 17th, 2013, 4:19 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:











 

  


Review request for KDE Frameworks, kdelibs and David Faure.


By Martin Tobias Holmedahl Sandsmark.




Updated March 17, 2013, 4:19 p.m.








Description 

 

 

  
   
Port KRun to use QProcess instead of KProcess.

Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory.

  		
 









Diffs 


    

 
  • kio/kio/krun.cpp (76b7385)
    • 

 
  • kio/kio/krun_p.h (01abb69)
    • 





View Diff








  		
 











  

 



--===============6306853446643583513==--

--===============8983173595285472773==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

--===============8983173595285472773==--