'Review Request 109551: port KPtyProcess to QProcess'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 109551: port KPtyProcess to QProcess
From:       "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date:       2013-03-17 16:44:09
Message-ID: 20130317164409.25034.57657 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/
-----------------------------------------------------------

Review request for KDE Frameworks, kdelibs and David Faure.

Description
-------

Just a simple port of KPtyProcess away from using KProcess.

Diffs
-----

  kpty/kptyprocess.h 5e0df96 
  kpty/kptyprocess.cpp 015a58c 
  kpty/tests/kptyprocesstest.h 64bded0 
  kpty/tests/kptyprocesstest.cpp 04990a0 

Diff: http://git.reviewboard.kde.org/r/109551/diff/

Testing
-------

builds and tests pass.

Thanks,

Martin Tobias Holmedahl Sandsmark

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109551/">http://git.reviewboard.kde.org/r/109551/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, kdelibs and David Faure.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just a simple port of KPtyProcess away from \
using KProcess.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds and tests pass.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kpty/kptyprocess.h <span style="color: grey">(5e0df96)</span></li>

 <li>kpty/kptyprocess.cpp <span style="color: grey">(015a58c)</span></li>

 <li>kpty/tests/kptyprocesstest.h <span style="color: grey">(64bded0)</span></li>

 <li>kpty/tests/kptyprocesstest.cpp <span style="color: grey">(04990a0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109551/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 