[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: KArchive for Qt4
From:       Sune Vuorela <nospam () vuorela ! dk>
Date:       2012-11-17 19:09:00
Message-ID: slrnkafocg.me.nospam () sshway ! ssh ! pusling ! com
[Download RAW message or body]

On 2012-11-17, Alexander Neundorf <neundorf@kde.org> wrote:
> On Thursday 15 November 2012, Sune Vuorela wrote:
>> On 2012-11-15, Alexander Neundorf <neundorf@kde.org> wrote:
>> >> I thought we earlier agreed on things like "you should not inherit
>> >> sonames from other modules" and such.
>> 
>> We have apparantly a ECM_SOVERSION coming from somewhere and used.
>> 
>> >> and we just have layers of added complexity that seems to be added for
>> >> the sake of complexity.
>> > 
>> > What do you mean exactly ?
>> 
>> We have a generated config file that I still haven't figured out where
>> it comes from (and which is quite buggy 
>
> What exactly is buggy in the file ?

at least the two following things (which is taken from memory, so there
might be typing issues)

threadweaver_LIBRARY is just "threadweaver". I needed to figure out how
to add LINK_DIRECTORIES(${threadweaver_DIR}) the right places as well.
that was at least ... unexpected.

the variable for includes is not complete. you include most bits by
doing include <threadweaver/foo>, but threadweaver/foo includes
"threadweaver_export.h", so the threadweaver_INCLUDE_DIR variable isn't
complete enough. I needed
include_directories(${threadweaver_INCLUDE_DIR}
${threadweaver_INCLUDE_DIR}/threadweaver) to get it to be used.

and when I was doing a installer on windows (where I need to include the
threadweaver.dll file) I had to do like
INSTALL(${CMAKE_INSTALL_PREFIX}/bin/lib${threadweaver_LIBRARY}.dll
DESTINATION bin) but I_think that's jsut a extra way of showing the
first issue.

So basically, getting the library to link and getting the include paths
was broken.

/Sune

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]