[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request: Port some uses of KUrl to QUrl
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2012-09-20 21:34:17
Message-ID: 20120920213417.31829.59295 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106501/#review19241
-----------------------------------------------------------
kio/tests/krununittest.cpp
<http://git.reviewboard.kde.org/r/106501/#comment15262>
this whole hunk doesn't belong into this patch at all. one part of it b=
elongs into the kprocess patch, the other (the kdesuExe part) is a commit o=
f its own.
- Oswald Buddenhagen
On Sept. 19, 2012, 10:19 p.m., Kevin Funk wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106501/
> -----------------------------------------------------------
> =
> (Updated Sept. 19, 2012, 10:19 p.m.)
> =
> =
> Review request for KDE Frameworks.
> =
> =
> Description
> -------
> =
> Port some uses of KUrl to QUrl
> =
> =
> kio: Cleanup header a bit
> =
> =
> kio: Merge some functions using default arguments
> =
> =
> kio: Mark test with QSKIP_PORTING
> =
> =
> Diffs
> -----
> =
> kio/kio/krun.h 7bfe66b59f1deffc37d3ceae999fb929e453fd31 =
> kio/kio/krun.cpp 031dbc1dfef685729038b4a59cbeacd34d448ed2 =
> kio/tests/kruntest.h 6f5eae6147e2fbef25025976a17869af4d0f12f9 =
> kio/tests/kruntest.cpp 92496bd1d4b98ea8f7dc13977cd3d2aa0dae7145 =
> kio/tests/krununittest.cpp 314da79b9ee4f95bcc9f768a95810f7de3125ac1 =
> =
> Diff: http://git.reviewboard.kde.org/r/106501/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Kevin Funk
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106501/">http://git.reviewboard.kde.org/r/106501/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106501/diff/2/?file=86400#file86400line127" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kio/tests/krununittest.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KRunUnitTest::testProcessDesktopExec()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">127</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Find \
out the full path of the shell which will be used to execute shell \
commands</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">127</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span \
class="n">QString</span> <span class="n">kdesuExe</span> <span class="o">=</span> \
<span class="n">QStandardPaths</span><span class="o">::</span><span \
class="n">findExecutable</span><span class="p">(</span><span \
class="s">"kdesu"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this whole \
hunk doesn't belong into this patch at all. one part of it belongs into the \
kprocess patch, the other (the kdesuExe part) is a commit of its own.</pre> </div>
<br />
<p>- Oswald</p>
<br />
<p>On September 19th, 2012, 10:19 p.m., Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2012, 10:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port some uses of KUrl to QUrl
kio: Cleanup header a bit
kio: Merge some functions using default arguments
kio: Mark test with QSKIP_PORTING</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/krun.h <span style="color: \
grey">(7bfe66b59f1deffc37d3ceae999fb929e453fd31)</span></li>
<li>kio/kio/krun.cpp <span style="color: \
grey">(031dbc1dfef685729038b4a59cbeacd34d448ed2)</span></li>
<li>kio/tests/kruntest.h <span style="color: \
grey">(6f5eae6147e2fbef25025976a17869af4d0f12f9)</span></li>
<li>kio/tests/kruntest.cpp <span style="color: \
grey">(92496bd1d4b98ea8f7dc13977cd3d2aa0dae7145)</span></li>
<li>kio/tests/krununittest.cpp <span style="color: \
grey">(314da79b9ee4f95bcc9f768a95810f7de3125ac1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106501/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic