'Review Request: do translation correctly in solid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request: do translation correctly in solid
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2012-08-09 13:24:38
Message-ID: 20120809132438.29500.91190 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105944/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.

Description
-------

use QCoreApplication::translate() and QT_TRANSLATE_NOOP

Diffs
-----

  tier1/solid/src/solid/backends/fstab/fstabmanager.cpp ad1ef4a39ba3c24746d=
f7cff811257a29716cbf6 =

  tier1/solid/src/solid/backends/hal/haldevice.cpp 0fecac17158728814e17b880=
70f22d105ae36574 =

  tier1/solid/src/solid/backends/kupnp/internetgatewaydevice1.cpp 1d7baf4f9=
fd97494c598478244252142c3beec73 =

  tier1/solid/src/solid/backends/kupnp/kupnpdevice.cpp 2aa01469cf76bf458eaa=
830f310be6f0de642770 =

  tier1/solid/src/solid/backends/kupnp/kupnprootdevice.cpp ce4818490a8b5bce=
4b0af8305d551105d6eeab62 =

  tier1/solid/src/solid/backends/kupnp/mediaserver1.cpp 02d8e558ad733d599bf=
c0efc419ddbaeb87e3eb0 =

  tier1/solid/src/solid/backends/kupnp/mediaserver2.cpp fd91b098e4ce4657bc1=
e8788794636618397c717 =

  tier1/solid/src/solid/backends/kupnp/mediaserver3.cpp cd5ad312e9e0ac6c45e=
11fb037ade2104a5fbbfd =

  tier1/solid/src/solid/backends/udev/udevdevice.cpp 21b97432b9bd6a93eaee2f=
6190cf0bf215ee6f94 =

  tier1/solid/src/solid/backends/udev/udevmanager.cpp c29f175f0a313256fda2e=
e8adb6895e7384574c2 =

  tier1/solid/src/solid/backends/udisks/udisksdevice.cpp 20d5654f7a0dc5c257=
ec7b80aa2f0db0c0315df5 =

  tier1/solid/src/solid/backends/udisks/udisksmanager.cpp 28f7bda8675e92f6c=
f90069b73e8e28b5c09873e =

  tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp 3076278a3eab67356=
0cbb38019bd2d8606f57610 =

  tier1/solid/src/solid/backends/udisks2/udisksmanager.cpp 0a77c163983e1f71=
916993bd0c4a3db78a9c020a =

  tier1/solid/src/solid/backends/upnp/upnpdevicemanager.cpp 985afb0d3707369=
f0076ea53f9418d08400badc6 =

  tier1/solid/src/solid/backends/upower/upowerdevice.cpp 39eec4f13516b6022e=
870b4de629c3bfc34b6607 =

  tier1/solid/src/solid/backends/upower/upowermanager.cpp c17afb946d30dea25=
eec90e51a9665b33e14bb81 =

  tier1/solid/src/solid/backends/wmi/wmibattery.cpp 4319ab50d3dbbe309c02691=
b32a69573581a78e5 =

  tier1/solid/src/solid/backends/wmi/wmidevice.cpp 157c6a96221621223e0f8219=
1ea512e58186afdf =

  tier1/solid/src/solid/deviceinterface.cpp 6c4d3f189936ff1bbd0b8c4ee651dd6=
bef8bfe4b =

Diff: http://git.reviewboard.kde.org/r/105944/diff/

Testing
-------

compiles

Thanks,

George Goldberg

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105944/">http://git.reviewboard.kde.org/r/105944/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By George Goldberg.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">use QCoreApplication::translate() and QT_TRANSLATE_NOOP</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tier1/solid/src/solid/backends/fstab/fstabmanager.cpp <span style="color: \
grey">(ad1ef4a39ba3c24746df7cff811257a29716cbf6)</span></li>

 <li>tier1/solid/src/solid/backends/hal/haldevice.cpp <span style="color: \
grey">(0fecac17158728814e17b88070f22d105ae36574)</span></li>

 <li>tier1/solid/src/solid/backends/kupnp/internetgatewaydevice1.cpp <span \
style="color: grey">(1d7baf4f9fd97494c598478244252142c3beec73)</span></li>

 <li>tier1/solid/src/solid/backends/kupnp/kupnpdevice.cpp <span style="color: \
grey">(2aa01469cf76bf458eaa830f310be6f0de642770)</span></li>

 <li>tier1/solid/src/solid/backends/kupnp/kupnprootdevice.cpp <span style="color: \
grey">(ce4818490a8b5bce4b0af8305d551105d6eeab62)</span></li>

 <li>tier1/solid/src/solid/backends/kupnp/mediaserver1.cpp <span style="color: \
grey">(02d8e558ad733d599bfc0efc419ddbaeb87e3eb0)</span></li>

 <li>tier1/solid/src/solid/backends/kupnp/mediaserver2.cpp <span style="color: \
grey">(fd91b098e4ce4657bc1e8788794636618397c717)</span></li>

 <li>tier1/solid/src/solid/backends/kupnp/mediaserver3.cpp <span style="color: \
grey">(cd5ad312e9e0ac6c45e11fb037ade2104a5fbbfd)</span></li>

 <li>tier1/solid/src/solid/backends/udev/udevdevice.cpp <span style="color: \
grey">(21b97432b9bd6a93eaee2f6190cf0bf215ee6f94)</span></li>

 <li>tier1/solid/src/solid/backends/udev/udevmanager.cpp <span style="color: \
grey">(c29f175f0a313256fda2ee8adb6895e7384574c2)</span></li>

 <li>tier1/solid/src/solid/backends/udisks/udisksdevice.cpp <span style="color: \
grey">(20d5654f7a0dc5c257ec7b80aa2f0db0c0315df5)</span></li>

 <li>tier1/solid/src/solid/backends/udisks/udisksmanager.cpp <span style="color: \
grey">(28f7bda8675e92f6cf90069b73e8e28b5c09873e)</span></li>

 <li>tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp <span style="color: \
grey">(3076278a3eab673560cbb38019bd2d8606f57610)</span></li>

 <li>tier1/solid/src/solid/backends/udisks2/udisksmanager.cpp <span style="color: \
grey">(0a77c163983e1f71916993bd0c4a3db78a9c020a)</span></li>

 <li>tier1/solid/src/solid/backends/upnp/upnpdevicemanager.cpp <span style="color: \
grey">(985afb0d3707369f0076ea53f9418d08400badc6)</span></li>

 <li>tier1/solid/src/solid/backends/upower/upowerdevice.cpp <span style="color: \
grey">(39eec4f13516b6022e870b4de629c3bfc34b6607)</span></li>

 <li>tier1/solid/src/solid/backends/upower/upowermanager.cpp <span style="color: \
grey">(c17afb946d30dea25eec90e51a9665b33e14bb81)</span></li>

 <li>tier1/solid/src/solid/backends/wmi/wmibattery.cpp <span style="color: \
grey">(4319ab50d3dbbe309c02691b32a69573581a78e5)</span></li>

 <li>tier1/solid/src/solid/backends/wmi/wmidevice.cpp <span style="color: \
grey">(157c6a96221621223e0f82191ea512e58186afdf)</span></li>

 <li>tier1/solid/src/solid/deviceinterface.cpp <span style="color: \
grey">(6c4d3f189936ff1bbd0b8c4ee651dd6bef8bfe4b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105944/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 