[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request: remove FindLibLZMA.cmake from karchive framework
From: "George Goldberg" <grundleborg () googlemail ! com>
Date: 2012-08-05 15:19:03
Message-ID: 20120805151903.30409.88308 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 5, 2012, 3:11 p.m., Alexander Neundorf wrote:
> > Where have you seen this ?
> > CMake 2.8.8 does not, and 2.8.9 has not yet been released.
> >
Ah, seems my distro packaged the RC's of 2.8.9 which is where I got it from=
. This change can wait until its released and whenever we depend on it.
- George
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105866/#review16896
-----------------------------------------------------------
On Aug. 5, 2012, 9:43 a.m., George Goldberg wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105866/
> -----------------------------------------------------------
> =
> (Updated Aug. 5, 2012, 9:43 a.m.)
> =
> =
> Review request for KDE Frameworks, Mario Bensi and David Faure.
> =
> =
> Description
> -------
> =
> CMake now appears to ship with an equivalent, which worked fine for me bu=
ilding the karchive framework.
> =
> =
> Diffs
> -----
> =
> tier1/karchive/cmake/FindLibLZMA.cmake 1a341b28effa9a54d6e27c4e7f3704f3=
473921e8 =
> =
> Diff: http://git.reviewboard.kde.org/r/105866/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> George Goldberg
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105866/">http://git.reviewboard.kde.org/r/105866/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 5th, 2012, 3:11 p.m., <b>Alexander \
Neundorf</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Where have you seen this ? CMake 2.8.8 does not, and 2.8.9 has not yet \
been released. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, seems my distro \
packaged the RC's of 2.8.9 which is where I got it from. This change can wait \
until its released and whenever we depend on it.</pre> <br />
<p>- George</p>
<br />
<p>On August 5th, 2012, 9:43 a.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, Mario Bensi and David Faure.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2012, 9:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CMake now appears to ship with an equivalent, which worked fine for me \
building the karchive framework.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/karchive/cmake/FindLibLZMA.cmake <span style="color: \
grey">(1a341b28effa9a54d6e27c4e7f3704f3473921e8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105866/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic