[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: libkwidgets (Re: patches on kcolors)
From: Giorgos Tsiapaliwkas <terietor () gmail ! com>
Date: 2012-04-11 12:21:59
Message-ID: CAODYyLaka5j+_6e116_MaFmqzYJxXdPeGj0Qxct7nNUtTWkt0w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On 11 April 2012 14:55, Stephen Kelly <steveire@gmail.com> wrote:
>
> It's not clear which patch you're talking about. As far as I can see, you
> didn't really post the patches individually, but just posted the moevs that
> you made along with the CMakeLists changes you made (as one patch).
>
yes it is one patch because I don't see why I should split this patch into
more.
I did them all in one patch because they depend on each other.
> I'd suggest you try to move fewer things at once and make sure the entire
> branch builds (not just the parts you move). You want to move the things at
> the bottom of the dependency tree first.
>
I can't due to the buildsystem. Every move that I make creates a lot of
undef refs.
> Yes, you can post the patches here for review. The best would be to use git
> show -M -C <sha1> to create the patches so we can review them and I can do
> a
> build to make sure it builds.
What's the difference from what I am doing?
I copy&paste the moves and I give you the diff which has the changes.
> Probably not. Lets review it first.
ok, I am waiting :)
> >
> > Have you seen my issue about splitting?
> > Also with all this cherry pick now we can't merge my branch. Right?
>
> It's better that I cherry pick from your branch so that history remains
> buildable, or that you move files, post patches for review, I'll do a test
> build, and one of us push the result.
>
I agree, I think that its better if you make the cherry pick.
> I'm still not sure I understand the goals of your moves though. What
> classes
> do you still want to move? Do you have some kind of plan, or are you just
> trying to move everything from kdeui a few classes at a time? Why not just
> rename kdeui? Why rename kdeui? Do you plan on addressing any of the causes
> of interdependencies?
>
my work here at the frameworks started at the first KF day, you told me to
do it like this
and I did.
> I'd suggest that a better contribution would be to analyse what
> dependencies
> exist and why. For example, look at KLed. It depends on the colors stuff
> that is now in kdeguiaddons. Does it need to?
I don't consider me as the best person for this work. Why?
Because I don't trust my decisions, our frameworks is a heavy job and I
can't take such calls.
Also in order to this I have to study all that code, which requires a lot
of time and I don't volunteer for
that. I prefer someone who has the appropriate experience to tell me what
to do.
Regards,
Giorgos
--
Giorgos Tsiapaliwkas (terietor)
KDE Developer
terietor.gr
[Attachment #5 (text/html)]
<div dir="ltr"><br><br><div class="gmail_quote">On 11 April 2012 14:55, Stephen Kelly \
<span dir="ltr"><<a \
href="mailto:steveire@gmail.com">steveire@gmail.com</a>></span> wrote:<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div class="im">It's not clear which patch you're \
talking about. As far as I can see, you</div> didn't really post the patches \
individually, but just posted the moevs that<br> you made along with the CMakeLists \
changes you made (as one patch).<br></blockquote><div><br></div><div>yes it is one \
patch because I don't see why I should split this patch into more.</div><div>I \
did them all in one patch because they depend on each other.</div> <div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> I'd suggest you try to move fewer things at once and \
make sure the entire<br> branch builds (not just the parts you move). You want to \
move the things at<br> the bottom of the dependency tree \
first.<br></blockquote><div><br></div><div>I can't due to the buildsystem. Every \
move that I make creates a lot of undef refs.</div><div><br></div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Yes, you can post the patches here for review. The best \
would be to use git<br> show -M -C <sha1> to create the patches so we can \
review them and I can do a<br> build to make sure it \
builds.</blockquote><div><br></div><div>What's the difference from what I am \
doing?</div><div>I copy&paste the moves and I give you the diff which has the \
changes.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> Probably not. Lets review it \
first.</blockquote><div><br></div><div>ok, I am waiting :)</div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="im">
><br>
> Have you seen my issue about splitting?<br>
> Also with all this cherry pick now we can't merge my branch. Right?<br>
<br>
</div>It's better that I cherry pick from your branch so that history remains<br>
buildable, or that you move files, post patches for review, I'll do a test<br>
build, and one of us push the result.<br></blockquote><div><br></div><div>I agree, I \
think that its better if you make the cherry pick.</div><div> </div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
I'm still not sure I understand the goals of your moves though. What classes<br>
do you still want to move? Do you have some kind of plan, or are you just<br>
trying to move everything from kdeui a few classes at a time? Why not just<br>
rename kdeui? Why rename kdeui? Do you plan on addressing any of the causes<br>
of interdependencies?<br></blockquote><div><br></div><div>my work here at the \
frameworks started at the first KF day, you told me to do it like this</div><div>and \
I did.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
I'd suggest that a better contribution would be to analyse what dependencies<br>
exist and why. For example, look at KLed. It depends on the colors stuff<br>
that is now in kdeguiaddons. Does it need to?</blockquote></div><br>I don't \
consider me as the best person for this work. Why?<div>Because I don't trust my \
decisions, our frameworks is a heavy job and I can't take such calls.</div> \
<div>Also in order to this I have to study all that code, which requires a lot of \
time and I don't volunteer for</div><div>that. I prefer someone who has the \
appropriate experience to tell me what to do.</div><div><br> \
</div><div>Regards,</div><div>Giorgos</div><div><br><div><div>-- <br>Giorgos \
Tsiapaliwkas (terietor)<br>KDE Developer<br><br><a href="http://terietor.gr" \
target="_blank">terietor.gr</a><br> </div></div></div></div>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic