[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Simplifying QtGui includes?
From:       Sebastian_Trüg <sebastian () trueg ! de>
Date:       2012-02-05 13:02:07
Message-ID: 4F2E7DCF.4030509 () trueg ! de
[Download RAW message or body]

Hi Stephen,

would you mind writing down all these little changes you do en masse on
some wiki page so others wanting to port to frameworks can benefit from it?
Maybe including the regex you use for replacing stuff and so on.

Cheers,
Sebastian

On 02/02/2012 10:39 AM, Stephen Kelly wrote:
> David Faure wrote:
> 
>> On Wednesday 01 February 2012 18:02:17 Stephen Kelly wrote:
>>> Hi,
>>>
>>> One of the big changes in Qt5 is the split of parts of QtGui into
>>> QtWidgets.
>>>
>>> That means for example that includes such as
>>>
>>> #include <QtGui/QDialog>
>>>
>>> will no longer work. Includes with the module will have to look like:
>>>
>>> #include <QtWidgets/QDialog>
>>>
>>> However,
>>>
>>> #include <QDialog>
>>>
>>> works in both cases (Qt 4 and 5).
>>>
>>> I would like to remove the 'QtGui/' en-masse from kdelibs. This will
>>> allow me and others to easy test porting to Qt5. As the QtModule
>>> directories are always part of our include_directories, I see no
>>> disadvantage.
>>>
>>> Any objections?
>>
>> Go for it. I never liked the explicit module names in includes, and now I
>> have a pretty good argument against them: the above.
>>
> 
> Done, thanks.
> 
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]