From kde-finance-apps Thu Jul 01 21:34:37 2021 From: Ralf Habacker Date: Thu, 01 Jul 2021 21:34:37 +0000 To: kde-finance-apps Subject: Re: GSoC '21 KMyMoney : I am stuck. Message-Id: <70b9a863-f9fa-905a-b010-f13626020c48 () freenet ! de> X-MARC-Message: https://marc.info/?l=kde-finance-apps&m=162517529111254 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--------------B0E2C46DFA4EAE450FC549CD" This is a multi-part message in MIME format. --------------B0E2C46DFA4EAE450FC549CD Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Am 25.06.21 um 18:22 schrieb Thomas Baumgart: > Hi, > > On Freitag, 25. Juni 2021 00:00:33 CEST Suraj Kumar Mahto wrote: > >> Hello, >> I think I have fixed the crash bug. Please note that the online quote editor is intended to support multiple applications and therefore adds multiple profiles, where the usage of AlkOnlineQuotesWidget inside kmymoney only needs one specific profile |manager.addProfile(new AlkOnlineQuotesProfile("kmymoney5", AlkOnlineQuotesProfile::Type::KMyMoney5, "kmymoney-quotes.knsrc"));| |Regards| |Ralf | >> Thank you very much for the help. I did >> the changes in kmymoney repo only and I have pushed those changes to >> https://invent.kde.org/surajsloth/kmymoney/-/tree/gsoc21 . I have pushed >> the changes. Although the new quote button is disabled. That is needed to >> be figured out. > I am sure, that you can figure that out. If you have trouble, I can also > take a look at it and give you some guidance. > >> My forked changes(gsoc21 branch) can be merged into gsoc21 branch of the >> upstream repo. This way I am dealing with a forked repo also and my entire >> work is there is a separate branch of upstream repo. What do you think >> about this? > Doing the work in your fork is just fine. Keep it in the fork and once > you're done, we can pull it into the KMyMoney main repo with a merge request. > There is no need to keep a gsoc21 branch in the KMyMoney repo in sync. > > I have a clone of your forked repo here on my system where I can checkout > your current state from the fork and help you out if needed. It is very > helpful if you sync with KMyMoney master every now and then as you did > today. > --------------B0E2C46DFA4EAE450FC549CD Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit
Am 25.06.21 um 18:22 schrieb Thomas Baumgart:
Hi,

On Freitag, 25. Juni 2021 00:00:33 CEST Suraj Kumar Mahto wrote:


Hello,
I think I have fixed the crash bug.

Please note that the online quote editor is intended to support multiple applications and therefore adds multiple profiles, where the usage of AlkOnlineQuotesWidget inside kmymoney only needs one specific profile

manager.addProfile(new AlkOnlineQuotesProfile("kmymoney5", AlkOnlineQuotesProfile::Type::KMyMoney5, "kmymoney-quotes.knsrc"));

Regards

Ralf
 

Thank you very much for the help. I did
the changes in kmymoney repo only and I have pushed those changes to
https://invent.kde.org/surajsloth/kmymoney/-/tree/gsoc21 . I have pushed
the changes. Although the new quote button is disabled. That is needed to
be figured out.


    

      
I am sure, that you can figure that out. If you have trouble, I can also
take a look at it and give you some guidance.



      

        
My forked changes(gsoc21 branch) can be merged into gsoc21 branch of the
upstream repo. This way I am dealing with a forked repo also and my entire
work is there is a separate branch of upstream repo. What do you think
about this?


      

      
Doing the work in your fork is just fine. Keep it in the fork and once
you're done, we can pull it into the KMyMoney main repo with a merge request.
There is no need to keep a gsoc21 branch in the KMyMoney repo in sync.

I have a clone of your forked repo here on my system where I can checkout
your current state from the fork and help you out if needed. It is very
helpful if you sync with KMyMoney master every now and then as you did
today.



    

  


--------------B0E2C46DFA4EAE450FC549CD--