[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-finance-apps
Subject: Re: Changing code to load bank data from SQLite DB
From: Ralf Habacker <ralf.habacker () freenet ! de>
Date: 2020-07-02 21:48:26
Message-ID: 501eafa4-bf02-ca34-2a11-14febac27bdf () freenet ! de
[Download RAW message or body]
Am 02.07.20 um 23:39 schrieb Ralf Habacker:
> Am 24.06.20 um 10:29 schrieb Ralf Habacker:
>> ||
>> |//don't use me any moreDEPRECATED ||bool isDataValidForDate(std::time_t date) const; |
> This example may not use usefull. The DEPRECATED macro should only be
> used for functions, which are outdated|| and should
not
> be used anymore.||
|Regards||
Ralf |||
>> ||
>>>
>>>
>>> On Sun, 14 Jun 2020 at 01:35, Ralf Habacker
>>> <ralf.habacker@freenet.de <mailto:ralf.habacker@freenet.de>> wrote:
>>>
>>> Am 13.06.20 um 06:52 schrieb Prasun Kumar:
>>> > Hi mentors,
>>> > I have tested the SQLite database to implement
>>> > AccountNumberCheck::findbank() and it worked successfully. Now I'm
>>> > ready to change the present code.
>>> > So how should I make these commits? Should I replace the
>>> current code
>>> > by commenting them out
>>> No need for that as changes are recorded in git log
>>>
>>> or should I remove them altogether?
>>>
>>> yes, see above
>>>
>>> > Also, there are many methods which deal solely with textfile
>>> reading
>>> > such as dataValidStartDate(), dataValidEndDate(),
>>> isDataValidForDate(),
>>> > find_closest_datafile to name a few.
>>>
>>> > bool isDataValidForDate(std::time_t date) const;
>>> >
>>> > /** Returns true if a bankdata file valid for the given date is
>>> > * available, otherwise false.
>>> > *
>>> > * Whether this file has already been loaded has to be queried
>>> > * separately through isDataValidForDate().
>>> > *
>>> > * This function was introduced in ktoblzcheck-1.15.
>>> */
>>> This and the other methods are part of the public api and should
>>> not be
>>> removed as clients may depends on them.
>>>
>>> > To make the commits small, I would be making a commit for each
>>> method
>>> > change.
>>> yes, looks good.
>>>
>>> Regards
>>>
>>> Ralf
>>>
>>>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Am 02.07.20 um 23:39 schrieb Ralf
Habacker:<br>
</div>
<blockquote type="cite"
cite="mid:53c5596c-490f-5826-6202-552e701934fb@freenet.de">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">Am 24.06.20 um 10:29 schrieb Ralf
Habacker:<br>
</div>
<blockquote type="cite"
cite="mid:9c18b581-f70f-a773-7048-ed2618ad61fa@freenet.de">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<code><span class="pln"></span></code>
<pre class="lang-cpp prettyprint prettyprinted" style=""><code><span \
class="com">//don't use me any more</span><span class="pln"> DEPRECATED \
</span></code><code><span class="pln"><span class="gmail-im"></span>bool \
isDataValidForDate(std::time_t date) const; </span></code></pre>
</blockquote>
This example may not use usefull. The DEPRECATED macro should only
be used for functions, which are outdated<code><span class="pln"></span></code>
and should </blockquote>
not<br>
<blockquote type="cite"
cite="mid:53c5596c-490f-5826-6202-552e701934fb@freenet.de">be used
anymore.<code><span class="pln"> </span></code></blockquote>
<p><code><span class="pln">Regards</span></code><code><span
class="pln"><br>
Ralf
</span></code><code><span class="pln"></span></code></p>
<blockquote type="cite"
cite="mid:53c5596c-490f-5826-6202-552e701934fb@freenet.de">
<blockquote type="cite"
cite="mid:9c18b581-f70f-a773-7048-ed2618ad61fa@freenet.de">
<pre class="lang-cpp prettyprint prettyprinted" style=""><code><span \
class="pun"></span></code></pre> <blockquote type="cite"
cite="mid:CAM9DqsJ9Qc3pN9UmzJk9t2v3MrC1xdiUrUzfme7POiNzkm5CiQ@mail.gmail.com">
<div dir="ltr"><br>
<span class="gmail-im"></span>
<div><span class="gmail-im"></span></div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sun, 14 Jun 2020 at
01:35, Ralf Habacker <<a
href="mailto:ralf.habacker@freenet.de"
moz-do-not-send="true">ralf.habacker@freenet.de</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Am 13.06.20 um 06:52
schrieb Prasun Kumar:<br>
> Hi mentors,<br>
> I have tested the SQLite database to implement<br>
> AccountNumberCheck::findbank() and it worked
successfully. Now I'm<br>
> ready to change the present code.<br>
> So how should I make these commits? Should I replace
the current code<br>
> by commenting them out<br>
No need for that as changes are recorded in git log<br>
<br>
or should I remove them altogether?<br>
<br>
yes, see above<br>
<br>
> Also, there are many methods which deal solely with
textfile reading<br>
> such as dataValidStartDate(), dataValidEndDate(),
isDataValidForDate(),<br>
> find_closest_datafile to name a few.<br>
<br>
> bool isDataValidForDate(std::time_t date) const;<br>
><br>
> /** Returns true if a bankdata file valid for the
given date is<br>
> * available, otherwise false.<br>
> *<br>
> * Whether this file has already been loaded has to
be queried<br>
> * separately through isDataValidForDate().<br>
> *<br>
> * This function was introduced in ktoblzcheck-1.15.<br>
*/<br>
This and the other methods are part of the public api and
should not be<br>
removed as clients may depends on them.<br>
<br>
> To make the commits small, I would be making a commit
for each method<br>
> change.<br>
yes, looks good.<br>
<br>
Regards<br>
<br>
Ralf<br>
<br>
<br>
</blockquote>
</div>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic