[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D29836: Code refactoring unifying capture initialization for new sequences and continuing of sequenc
From:       Chris Rowland <noreply () phabricator ! kde ! org>
Date:       2020-05-31 21:53:23
Message-ID: a2c219606646e5aa7a8b12fbabcf775e () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

chrisrowland added a comment.


  I'm sorry but I don't think I am qualified to review a refactor of the 
  capture module because I do not have enough understanding of the capture 
  process to be able to contribute.
  
  I see no benefit in my nit picking about the code style.
  
  I should also point out that I've asked Jasem to revert the meridian 
  flip changes I made.  It looks as if there have been too many side 
  effects in other parts of the system and in other mount control systems 
  to make the changes viable for production code.  I don't know if 
  reverting that will affect this.
  
  Chris

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D29836

To: wreissenberger, mutlaqja, chrisrowland, TallFurryMan, murveit
Cc: yurchor, kde-edu, narvaez, apol

[Attachment #3 (text/html)]

<table><tr><td style="">chrisrowland added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D29836">View Revision</a></tr></table><br \
/><div><div><p>I&#039;m sorry but I don&#039;t think I am qualified to review a \
refactor of the <br /> capture module because I do not have enough understanding of \
the capture <br /> process to be able to contribute.</p>

<p>I see no benefit in my nit picking about the code style.</p>

<p>I should also point out that I&#039;ve asked Jasem to revert the meridian <br />
flip changes I made.  It looks as if there have been too many side <br />
effects in other parts of the system and in other mount control systems <br />
to make the changes viable for production code.  I don&#039;t know if <br />
reverting that will affect this.</p>

<p>Chris</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 \
KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D29836">https://phabricator.kde.org/D29836</a></div></div><br \
/><div><strong>To: </strong>wreissenberger, mutlaqja, chrisrowland, TallFurryMan, \
murveit<br /><strong>Cc: </strong>yurchor, kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]