[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D29549: Updates to SkyPoint to improve positions
From: Eric Dejouhanet <noreply () phabricator ! kde ! org>
Date: 2020-05-11 7:31:24
Message-ID: f80bc570e2f05eb9d278b51832a81b66 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
TallFurryMan added a comment.
This is excellent. Sorry to arrive late to the party, two comments from me, one \
about the test mode of QtTest, and the other about build failures with versions older \
than Qt 5.9.
INLINE COMMENTS
> test_skypoint.cpp:32
> +{
> + useRelativistic = Options::useRelativistic();
> +}
If you use Options, you may need to use `QStandardPaths::setTestModeEnabled` to \
prevent your changes from (1) depending on existing data and (2) modifying existing \
user data? Check the constructor of TestKSUserDB at \
https://github.com/KDE/kstars/blob/master/Tests/auxiliary/testksuserdb.cpp.
> test_skypoint.cpp:37
> +{
> + Options::setUseRelativistic(useRelativistic);
> +}
This will not be executed if the test crashes, hence modifying local user data.
> test_skypoint.cpp:247
> +{
> + QTest::addColumn<double>("Ra");
> + QTest::addColumn<double>("Dec");
You need to #ifdef this against Qt 5.9, see the example at \
`TestEkosSimulator::testMountSlew_data` at \
https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp.
> test_skypoint.cpp:262
> + SkyPoint sp;
> + QFETCH(double, Ra);
> + QFETCH(double, Dec);
You need to #ifdef this against Qt 5.9, see the example at \
`TestEkosSimulator::testMountSlew_data` at \
https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp.
> test_skypoint.cpp:293
> + SkyPoint sp;
> + QFETCH(double, Ra);
> + QFETCH(double, Dec);
Qt 5.9
> test_skypoint.cpp:324
> + SkyPoint sp;
> + QFETCH(double, Ra);
> + QFETCH(double, Dec);
Qt 5.9.
> test_skypoint.cpp:367
> + SkyPoint sp;
> + QFETCH(double, Ra);
> + QFETCH(double, Dec);
Qt 5.9.
> test_skypoint.cpp:393
> +{
> + QTest::addColumn<double>("Ra");
> + QTest::addColumn<double>("Dec");
Qt 5.9.
> test_skypoint.cpp:412
> + SkyPoint sp;
> + QFETCH(double, Ra);
> + QFETCH(double, Dec);
Qt 5.9.
REPOSITORY
R321 KStars
REVISION DETAIL
https://phabricator.kde.org/D29549
To: chrisrowland, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">TallFurryMan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D29549">View Revision</a></tr></table><br \
/><div><div><p>This is excellent. Sorry to arrive late to the party, two comments \
from me, one about the test mode of QtTest, and the other about build failures with \
versions older than Qt 5.9.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D29549#inline-169545">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">test_skypoint.cpp:32</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">useRelativistic</span> <span \
style="color: #aa2211">=</span> <span class="n">Options</span><span style="color: \
#aa2211">::</span><span class="n">useRelativistic</span><span class="p">();</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If \
you use Options, you may need to use <tt style="background: #ebebeb; font-size: \
13px;">QStandardPaths::setTestModeEnabled</tt> to prevent your changes from (1) \
depending on existing data and (2) modifying existing user data? Check the \
constructor of TestKSUserDB at <a \
href="https://github.com/KDE/kstars/blob/master/Tests/auxiliary/testksuserdb.cpp" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/KDE/kstars/blob/master/Tests/auxiliary/testksuserdb.cpp</a>.</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D29549#inline-169546">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">test_skypoint.cpp:37</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">Options</span><span style="color: \
#aa2211">::</span><span class="n">setUseRelativistic</span><span \
class="p">(</span><span class="n">useRelativistic</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
will not be executed if the test crashes, hence modifying local user \
data.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D29549#inline-169548">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">test_skypoint.cpp:247</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span \
class="n">addColumn</span><span style="color: #aa2211"><</span><span style="color: \
#aa4000">double</span><span style="color: #aa2211">></span><span \
class="p">(</span><span style="color: #766510">"Ra"</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: \
#aa2211">::</span><span class="n">addColumn</span><span style="color: \
#aa2211"><</span><span style="color: #aa4000">double</span><span style="color: \
#aa2211">></span><span class="p">(</span><span style="color: \
#766510">"Dec"</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
need to #ifdef this against Qt 5.9, see the example at <tt style="background: \
#ebebeb; font-size: 13px;">TestEkosSimulator::testMountSlew_data</tt> at <a \
href="https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp</a>.</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D29549#inline-169547">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">test_skypoint.cpp:262</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">SkyPoint</span> <span class="n">sp</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QFETCH</span><span class="p">(</span><span style="color: \
#aa4000">double</span><span class="p">,</span> <span class="n">Ra</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QFETCH</span><span \
class="p">(</span><span style="color: #aa4000">double</span><span class="p">,</span> \
<span class="n">Dec</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
need to #ifdef this against Qt 5.9, see the example at <tt style="background: \
#ebebeb; font-size: 13px;">TestEkosSimulator::testMountSlew_data</tt> at <a \
href="https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp</a>.</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D29549#inline-169549">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">test_skypoint.cpp:293</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">SkyPoint</span> <span class="n">sp</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QFETCH</span><span class="p">(</span><span style="color: \
#aa4000">double</span><span class="p">,</span> <span class="n">Ra</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QFETCH</span><span \
class="p">(</span><span style="color: #aa4000">double</span><span class="p">,</span> \
<span class="n">Dec</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Qt \
5.9</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D29549#inline-169550">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">test_skypoint.cpp:324</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">SkyPoint</span> <span class="n">sp</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QFETCH</span><span class="p">(</span><span style="color: \
#aa4000">double</span><span class="p">,</span> <span class="n">Ra</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QFETCH</span><span \
class="p">(</span><span style="color: #aa4000">double</span><span class="p">,</span> \
<span class="n">Dec</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Qt \
5.9.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D29549#inline-169551">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">test_skypoint.cpp:367</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">SkyPoint</span> <span class="n">sp</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QFETCH</span><span class="p">(</span><span style="color: \
#aa4000">double</span><span class="p">,</span> <span class="n">Ra</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QFETCH</span><span \
class="p">(</span><span style="color: #aa4000">double</span><span class="p">,</span> \
<span class="n">Dec</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Qt \
5.9.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D29549#inline-169552">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">test_skypoint.cpp:393</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span \
class="n">addColumn</span><span style="color: #aa2211"><</span><span style="color: \
#aa4000">double</span><span style="color: #aa2211">></span><span \
class="p">(</span><span style="color: #766510">"Ra"</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: \
#aa2211">::</span><span class="n">addColumn</span><span style="color: \
#aa2211"><</span><span style="color: #aa4000">double</span><span style="color: \
#aa2211">></span><span class="p">(</span><span style="color: \
#766510">"Dec"</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Qt \
5.9.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D29549#inline-169553">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">test_skypoint.cpp:412</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">SkyPoint</span> <span class="n">sp</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QFETCH</span><span class="p">(</span><span style="color: \
#aa4000">double</span><span class="p">,</span> <span class="n">Ra</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QFETCH</span><span \
class="p">(</span><span style="color: #aa4000">double</span><span class="p">,</span> \
<span class="n">Dec</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Qt \
5.9.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D29549">https://phabricator.kde.org/D29549</a></div></div><br \
/><div><strong>To: </strong>chrisrowland, mutlaqja, TallFurryMan<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic