[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D27583: rebuild mosaic multiple dataset
From:       Timothée_Giet <noreply () phabricator ! kde ! org>
Date:       2020-03-29 16:39:38
Message-ID: 642c315ad076ca97c94aea04ecd1c994 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

timotheegiet accepted this revision.
timotheegiet added a comment.
This revision is now accepted and ready to land.


  After checking again the discussion here and on the tasks, and testing again the \
patch, I think it is good to go.  Adding the optional OK  button can be done later, \
it is not really part of the dataset changes.  
  And for the remaining work, that is all related to layout, so I will work on it \
after merging the patch.

REPOSITORY
  R2 GCompris

BRANCH
  mosaic_mdataset

REVISION DETAIL
  https://phabricator.kde.org/D27583

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">timotheegiet accepted this revision.<br />timotheegiet added \
a comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27583">View \
Revision</a></tr></table><br /><div><div><p>After checking again the discussion here \
and on the tasks, and testing again the patch, I think it is good to go.<br /> Adding \
the optional OK  button can be done later, it is not really part of the dataset \
changes.</p>

<p>And for the remaining work, that is all related to layout, so I will work on it \
after merging the patch.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>mosaic_mdataset</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D27583">https://phabricator.kde.org/D27583</a></div></div><br \
/><div><strong>To: </strong>dekumar, GCompris: Improvements, jjazeix, timotheegiet, \
echarruau<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]