[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D27583: rebuild mosaic multiple dataset
From: Johnny Jazeix <noreply () phabricator ! kde ! org>
Date: 2020-03-09 19:00:47
Message-ID: f223d39d485468b33193efcf7a5a35fd () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
jjazeix added a comment.
I'm wondering if we should not have the image names in the dataset too so later we \
can choose which images to display
INLINE COMMENTS
> Mosaic.qml:70
> + property int questionLayoutRows
> + property var dataType
> }
it seems to be a string?
> Mosaic.qml:145
> spacing: 10
> - columns: column.horizontal ? 2 : 1
> + columns: column.verticalMode ? (column.horizontal ? 1 : 1) : \
> (column.horizontal ? 2 : 1)
why (column.horizontal ? 1 : 1)?
> Data.qml:33
> + ],
> + "dataType": "data1"
> +
it's not intuitive, we don't know what it means or does. Can you rename it?
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D27583
To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau
Cc: kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D27583">View Revision</a></tr></table><br \
/><div><div><p>I'm wondering if we should not have the image names in the \
dataset too so later we can choose which images to display</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D27583#inline-157974">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Mosaic.qml:70</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #004012">property</span> <span style="color: #304a96">int</span> \
<span style="color: #004012">questionLayoutRows</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span \
style="color: #004012">dataType</span> </div><div style="padding: 0 8px; margin: 0 \
4px; "> <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it \
seems to be a string?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D27583#inline-157971">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Mosaic.qml:145</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#aa4000">spacing:</span> <span style="color: #601200">10</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<span style="color: #aa4000">columns:</span> <span style="color: \
#004012">column</span><span class="p">.</span><span style="color: \
#004012">horizontal</span> <span style="color: #aa2211">?</span> <span style="color: \
#601200">2</span> <span style="color: #aa2211">:</span> <span style="color: \
#601200">1</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">columns:</span> <span style="color: #004012">column</span><span \
class="p">.<span class="bright"></span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">verticalMode</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">?</span></span><span class="bright"> </span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">column</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">horizontal</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">?</span></span><span class="bright"> </span><span style="color: \
#601200"><span class="bright">1</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> \
</span><span style="color: #601200"><span class="bright">1</span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">:</span></span><span class="bright"> </span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">column</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span style="color: \
#004012">horizontal</span> <span style="color: #aa2211">?</span> <span style="color: \
#601200">2</span> <span style="color: #aa2211">:</span> <span style="color: \
#601200">1<span class="bright"></span></span><span class="bright"></span><span \
class="p"><span class="bright">)</span></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why \
(column.horizontal ? 1 : 1)?</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D27583#inline-157973">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Data.qml:33</span></div> <div style="font: \
11px/15px "Menlo", "Consolas", "Monaco", monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="p">],</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#766510">"dataType"</span><span style="color: #aa2211">:</span> <span \
style="color: #766510">"data1"</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">it's not intuitive, we don't know what it means or does. Can you \
rename it?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D27583">https://phabricator.kde.org/D27583</a></div></div><br \
/><div><strong>To: </strong>dekumar, GCompris: Improvements, jjazeix, timotheegiet, \
echarruau<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic