[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D27715: Port to Qt 5.14 + Android
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2020-02-28 10:00:43
Message-ID: e528a38181271a6608ae81af4b2b4cfe () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

apol added a comment.


  In D27715#619276 <https://phabricator.kde.org/D27715#619276>, @vkrause wrote:
  
  > Interesting, why is libs.xml checked in here? Usually androiddeployqt provides \
that I think. This might be a possible way out of the compatibility problem though: \
if libs.xml just defines all arrays the manifest can contain references to all of \
them as well, without breaking the build. Those not used in the corresponding Qt \
version will then just be empty but not cause any issue at runtime either.  >
  > In general this looks all correct to me and should work.
  
  
  It's entirely legacy reasons. I could remove it for sure.

INLINE COMMENTS

> vatra wrote in pluginsmodel.cpp:30
> What kind of plugins are you loading here? I hope you're not storing .so files in \
> "assets:" because it won't work

It's qml files.

REPOSITORY
  R325 KAlgebra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27715

To: apol, #android, vkrause
Cc: vatra, vkrause, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D27715">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D27715#619276" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D27715#619276</a>, <a \
href="https://phabricator.kde.org/p/vkrause/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@vkrause</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Interesting, why is libs.xml checked in \
here? Usually androiddeployqt provides that I think. This might be a possible way out \
of the compatibility problem though: if libs.xml just defines all arrays the manifest \
can contain references to all of them as well, without breaking the build. Those not \
used in the corresponding Qt version will then just be empty but not cause any issue \
at runtime either.</p>

<p>In general this looks all correct to me and should work.</p></div>
</blockquote>

<p>It&#039;s entirely legacy reasons. I could remove it for sure.</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D27715#inline-156673">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">vatra</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">pluginsmodel.cpp:30</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">What kind of \
plugins are you loading here? I hope you&#039;re not storing .so files in \
&quot;assets:&quot; because it won&#039;t work</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It&#039;s qml \
files.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R325 KAlgebra</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D27715">https://phabricator.kde.org/D27715</a></div></div><br \
/><div><strong>To: </strong>apol, Android, vkrause<br /><strong>Cc: </strong>vatra, \
vkrause, kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]