[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D26196: Add multiple dataset in guessnumber activity
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2020-01-28 18:16:21
Message-ID: 2986fc609bc04147b2e82a03e15a95ea () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jjazeix added inline comments.

INLINE COMMENTS

> AnswerArea.qml:70
> onUserEntryChanged: {
> +        userEntryText.text = ""
> if(userEntry != "")

There is still this thing that I'd like to be fixed.
By removing the binding on "text: answerBackground.userEntry", it does not reset the \
plane at the end of the level to the screen. Putting back the binding almost works \
fine, but there are issues when typing 0 that should be ignored if the answer if \
empty (if you type 0 twice at first level, you can't erase the actual number by \
typing 2 for example). Can you take a look at this?

REVISION DETAIL
  https://phabricator.kde.org/D26196

To: sambhavkaul, #gcompris_improvements
Cc: jjazeix, echarruau, kde-edu, vivekiit, sanjayshetty, parimalprasoon, harrymecwan, \
ganeshredcobra, asagtani, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, \
apol, timotheegiet, bcoudoin


[Attachment #3 (text/html)]

<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D26196">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D26196#inline-152598">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">AnswerArea.qml:70</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">    <span style="color: \
#aa4000">onUserEntryChanged:</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #004012">userEntryText</span><span class="p">.</span><span \
style="color: #004012">text</span> <span style="color: #aa2211">=</span> <span \
style="color: #766510">&quot;&quot;</span> </div><div style="padding: 0 8px; margin: \
0 4px; ">        <span style="color: #aa4000">if</span><span class="p">(</span><span \
style="color: #004012">userEntry</span> <span style="color: #aa2211">!=</span> <span \
style="color: #766510">&quot;&quot;</span><span class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">There is still this thing that I&#039;d like to be fixed.<br /> By removing the \
binding on &quot;text: answerBackground.userEntry&quot;, it does not reset the plane \
at the end of the level to the screen.<br /> Putting back the binding almost works \
fine, but there are issues when typing 0 that should be ignored if the answer if \
empty (if you type 0 twice at first level, you can&#039;t erase the actual number by \
typing 2 for example).<br /> Can you take a look at \
this?</p></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D26196">https://phabricator.kde.org/D26196</a></div></div><br \
/><div><strong>To: </strong>sambhavkaul, GCompris: Improvements<br /><strong>Cc: \
</strong>jjazeix, echarruau, kde-edu, vivekiit, sanjayshetty, parimalprasoon, \
harrymecwan, ganeshredcobra, asagtani, nityanandkumar, andreask, rahulyadav, narvaez, \
scagarwal, apol, timotheegiet, bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]