[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D25376: Load PHD2 star image from memory instead of temporary file
From:       Jarno Paananen <noreply () phabricator ! kde ! org>
Date:       2019-11-18 18:34:20
Message-ID: 88d42443dd38b8d7ad5ddf819c5f3d6b () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jarnopaananen created this revision.
jarnopaananen added reviewers: lancaster, mutlaqja.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
jarnopaananen requested review of this revision.

REVISION SUMMARY
  Currently Ekos saves the JSON formatted star image to temporary FITS file and loads \
it back, but CFitsio also supports simple memory file system that can be used instead \
saving writes to disk. Also reduces log spam as there is a debug print about each \
FITS load if debug logging is active.

TEST PLAN
  Use PHD2 as usual and observe star images still being shown.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D25376

AFFECTED FILES
  kstars/ekos/guide/externalguide/phd2.cpp

To: jarnopaananen, lancaster, mutlaqja
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">jarnopaananen created this revision.<br />jarnopaananen added \
reviewers: lancaster, mutlaqja.<br />Herald added a project: KDE Edu.<br />Herald \
added a subscriber: kde-edu.<br />jarnopaananen requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D25376">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Currently Ekos saves the JSON \
formatted star image to temporary FITS file and loads it back, but CFitsio also \
supports simple memory file system that can be used instead saving writes to disk. \
Also reduces log spam as there is a debug print about each FITS load if debug logging \
is active.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Use PHD2 as \
usual and observe star images still being shown.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D25376">https://phabricator.kde.org/D25376</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kstars/ekos/guide/externalguide/phd2.cpp</div></div></div><br \
/><div><strong>To: </strong>jarnopaananen, lancaster, mutlaqja<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]