[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D24352: Fix focus HFR-averaging bug
From:       Eric Dejouhanet <noreply () phabricator ! kde ! org>
Date:       2019-10-02 18:22:08
Message-ID: e1c04df1935adc8a29af4b1e4a14eacf () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

TallFurryMan added a comment.


  Good spot, I had missed this. But wouldn't it have been clearer to std::erase the \
result of each std::remove_if? This would have avoided the num_remaining gymnastics.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D24352

To: murveit, mutlaqja
Cc: TallFurryMan, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">TallFurryMan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D24352">View Revision</a></tr></table><br \
/><div><div><p>Good spot, I had missed this. But wouldn&#039;t it have been clearer \
to std::erase the result of each std::remove_if? This would have avoided the \
num_remaining gymnastics.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D24352">https://phabricator.kde.org/D24352</a></div></div><br \
/><div><strong>To: </strong>murveit, mutlaqja<br /><strong>Cc: </strong>TallFurryMan, \
kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]