[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D24006: Remove the usage of "null backend"
From: Nikita Sirgienko <noreply () phabricator ! kde ! org>
Date: 2019-09-17 10:11:57
Message-ID: 82462bb9424d06e311e0b2aef637029f () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
sirgienko requested changes to this revision.
sirgienko added a comment.
This revision now requires changes to proceed.
QDEBUG : WorksheetTest::testMathRender() PythonSession(0x5637c2e29f80) \
Cantor::VariableManagementExtension(0x5637c272c020, name = \
"VariableManagementExtension") QDEBUG : WorksheetTest::testMathRender() \
PythonHighlighter constructor FAIL! : WorksheetTest::testMathRender() Compared \
values are not the same Actual (rendered): 0
Expected (true) : 1
Loc: [/home/mmmm1998/Документы/Р\
епозитории/cantor/src/test/worksheet_test.cpp(6887)] QDEBUG : \
WorksheetTest::testMathRender2() PythonSession(0x5637c3250fb0) \
Cantor::VariableManagementExtension(0x5637c272c020, name = \
"VariableManagementExtension") QDEBUG : WorksheetTest::testMathRender2() \
PythonHighlighter constructor FAIL! : WorksheetTest::testMathRender2() Compared \
values are not the same Actual (rendered): 0
Expected (true) : 1
Loc: [/home/mmmm1998/Документы/Р\
епозитории/cantor/src/test/worksheet_test.cpp(6920)]
I don't fully understand, why the math render tests start to fail, but this occurs \
only with this patch, so the reason is the patch, i think. So, we need additional \
work on this patch.
INLINE COMMENTS
> cantor.cpp:188
> {
> - if (sender()->inherits("QAction"))
> + QAction* a = dynamic_cast<QAction*>(sender());
> + const QString& backendName = a->data().toString();
`dynamic_cast` without pointer validation - bad practise. Better use `static_cast` or \
check the poiter
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D24006
To: asemke, sirgienko, filipesaraiva
Cc: kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">sirgienko requested changes to this revision.<br />sirgienko \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24006">View \
Revision</a></tr></table><br /><div><div><div class="remarkup-code-block" \
style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre \
class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, \
120, 0.08);">QDEBUG : WorksheetTest::testMathRender() PythonSession(0x5637c2e29f80) \
Cantor::VariableManagementExtension(0x5637c272c020, name = \
"VariableManagementExtension") QDEBUG : WorksheetTest::testMathRender() \
PythonHighlighter constructor FAIL! : WorksheetTest::testMathRender() Compared \
values are not the same Actual (rendered): 0
Expected (true) : 1
Loc: [/home/mmmm1998/Документы/Р\
епозитории/cantor/src/test/worksheet_test.cpp(6887)] QDEBUG : \
WorksheetTest::testMathRender2() PythonSession(0x5637c3250fb0) \
Cantor::VariableManagementExtension(0x5637c272c020, name = \
"VariableManagementExtension") QDEBUG : WorksheetTest::testMathRender2() \
PythonHighlighter constructor FAIL! : WorksheetTest::testMathRender2() Compared \
values are not the same Actual (rendered): 0
Expected (true) : 1
Loc: [/home/mmmm1998/Документы/Р\
епозитории/cantor/src/test/worksheet_test.cpp(6920)]</pre></div>
<p>I don't fully understand, why the math render tests start to fail, but this \
occurs only with this patch, so the reason is the patch, i think.<br /> So, we need \
additional work on this patch.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D24006#inline-135911">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">cantor.cpp:188</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">if</span></span><span class="bright"> </span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span class="n"><span \
class="bright">sender</span></span><span class="bright"></span><span class="p"><span \
class="bright">()</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-></span></span><span class="bright"></span><span \
class="n"><span class="bright">inherits</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"</span>QAction<span class="bright">"</span></span><span \
class="bright"></span><span class="p"><span class="bright">))</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="bright"></span><span class="n"><span \
class="bright">QAction</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">*</span></span><span class="bright"> </span><span \
class="n"><span class="bright">a</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span style="color: #aa4000"><span \
class="bright">dynamic_cast</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright"><</span></span><span \
class="n">QAction<span class="bright"></span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">*></span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span class="bright">sender</span></span><span \
class="bright"></span><span class="p"><span class="bright">());</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">const</span> <span \
class="n">QString</span><span style="color: #aa2211">&</span> <span \
class="n">backendName</span> <span style="color: #aa2211">=</span> <span \
class="n">a</span><span style="color: #aa2211">-></span><span \
class="n">data</span><span class="p">().</span><span class="n">toString</span><span \
class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: 13px;">dynamic_cast</tt> without pointer \
validation - bad practise. Better use <tt style="background: #ebebeb; font-size: \
13px;">static_cast</tt> or check the poiter</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D24006">https://phabricator.kde.org/D24006</a></div></div><br \
/><div><strong>To: </strong>asemke, sirgienko, filipesaraiva<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic