[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D23533: Initialise default styles just once; display an icon for points
From:       John Zaitseff <noreply () phabricator ! kde ! org>
Date:       2019-08-28 11:21:58
Message-ID: d0fc4ea38eaab8b048868b91b3866856 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

zaitseff created this revision.
zaitseff added a reviewer: rahn.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
zaitseff requested review of this revision.

REVISION SUMMARY
  Previously, default styles would be constructed for every placemark.  Now create the default styles \
just once, then copy as required.  
  In addition, now display an icon for placemarks with points, but not for lines or polygons.  Currently, \
the icon cannot be styled with the Simplestyle properties "marker-size", "marker-symbol" or \
"marker-color": this is yet to be implemented.

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D23533

AFFECTED FILES
  src/plugins/runner/json/JsonParser.cpp
  src/plugins/runner/json/JsonParser.h

To: zaitseff, rahn
Cc: marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, \
narvaez, cmihalache, rahn, apol, nienhueser


[Attachment #3 (text/html)]

<table><tr><td style="">zaitseff created this revision.<br />zaitseff added a reviewer: rahn.<br />Herald \
added projects: Marble, KDE Edu.<br />Herald added subscribers: kde-edu, marble-devel.<br />zaitseff \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23533">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Previously, default styles would be constructed for every \
placemark.  Now create the default styles just once, then copy as required.</p>

<p>In addition, now display an icon for placemarks with points, but not for lines or polygons.  \
Currently, the icon cannot be styled with the Simplestyle properties &quot;marker-size&quot;, \
&quot;marker-symbol&quot; or &quot;marker-color&quot;: this is yet to be implemented.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R34 Marble</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D23533">https://phabricator.kde.org/D23533</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/plugins/runner/json/JsonParser.cpp<br /> \
src/plugins/runner/json/JsonParser.h</div></div></div><br /><div><strong>To: </strong>zaitseff, rahn<br \
/><strong>Cc: </strong>marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, chaz6, \
dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]