[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D22614: Correlation Coefficient (Pearson's r, Kendall Rank, Spearman Rank)
From:       Stefan Gerlach <noreply () phabricator ! kde ! org>
Date:       2019-07-22 16:35:23
Message-ID: 83938ee480e5b48466fdbb3eb23b083f () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sgerlach added inline comments.

INLINE COMMENTS

> devanshuagarwal wrote in HypothesisTest.cpp:158
> No std cant be < 0.
> 
> In starting I wrote
> 
>   if (std[i] == 0) {
>   }
> 
> but then it shows warning. 
> Comparing floating point with == or != is unsafe.
> 
> Hence I have used <=

you should do a floating point comparison like "std[i] < DBL_MIN" or use gsl_fcmp().

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22614

To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, #labplot, narvaez, apol

[Attachment #3 (text/html)]

<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D22614">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22614#inline-127961">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:158</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">No std cant be &lt; 0.</p>

<p style="padding: 0; margin: 8px;">In starting I wrote</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (std[i] == 0) { \
}</pre></div>

<p style="padding: 0; margin: 8px;">but then it shows warning. <br />
Comparing floating point with == or != is unsafe.</p>

<p style="padding: 0; margin: 8px;">Hence I have used &lt;=</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you \
should do a floating point comparison like &quot;std[i] &lt; DBL_MIN&quot; or use \
gsl_fcmp().</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D22614">https://phabricator.kde.org/D22614</a></div></div><br \
/><div><strong>To: </strong>devanshuagarwal, sgerlach, asemke<br /><strong>Cc: \
</strong>kde-edu, LabPlot, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]