[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D22496: Autmatic Test For Two Way ANOVA.
From: Stefan Gerlach <noreply () phabricator ! kde ! org>
Date: 2019-07-18 15:50:17
Message-ID: 855648d231f9ae5465d07ef9d651eba9 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
sgerlach added inline comments.
INLINE COMMENTS
> devanshuagarwal wrote in HypothesisTest.cpp:747
> The reason that I am doing so many basic calculations is to increase performance. \
> If I will use functions then I have to call separate functions for mean, std \
> deviation and other statistical calculations. Though asymptotically it will also \
> end up in O(n) but for practical purposes, it will turn out to be slower as here I \
> am transversing through the whole data only twice and there it will be f times \
> (where f >= number of statistical calculations)
I'm not sure if i understand your argument. You don't have to calculate it f times \
when you save the values. Also the performance should not be a problem. I would \
really recommend to use GSL function to improve readability and maintainability. Of \
course only if it fits to the workflow. Just think about it.
> devanshuagarwal wrote in HypothesisTest.cpp:843
> the translation is automatic in getHtmlTable3 function
ok
> devanshuagarwal wrote in HypothesisTest.cpp:849
> It is there in getHtmlTable3 method.
ok
> devanshuagarwal wrote in HypothesisTest.cpp:1375
> It is indented in the source file. I don't know why it is not shown in the \
> differnce file.
ok. This seems to happen sometimes.
REPOSITORY
R262 LabPlot
REVISION DETAIL
https://phabricator.kde.org/D22496
To: devanshuagarwal, Stefan, asemke
Cc: sgerlach, kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D22496">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22496#inline-127239">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:747</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">The reason that I am doing so many basic calculations is to increase \
performance. If I will use functions then I have to call separate functions for mean, \
std deviation and other statistical calculations. Though asymptotically it will also \
end up in O(n) but for practical purposes, it will turn out to be slower as here I am \
transversing through the whole data only twice and there it will be f times (where f \
>= number of statistical calculations)</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm not sure if i \
understand your argument. You don't have to calculate it f times when you save \
the values. Also the performance should not be a problem. I would really recommend to \
use GSL function to improve readability and maintainability. Of course only if it \
fits to the workflow. Just think about it.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22496#inline-127235">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:843</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">the translation is automatic in getHtmlTable3 function</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">ok</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D22496#inline-127240">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> \
wrote in <span style="color: #4b4d51; font-weight: \
bold;">HypothesisTest.cpp:849</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">It is there in \
getHtmlTable3 method.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">ok</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22496#inline-127236">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:1375</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">It is indented in the source file. I don't know why it is not shown in the \
differnce file.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">ok. This seems to happen \
sometimes.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D22496">https://phabricator.kde.org/D22496</a></div></div><br \
/><div><strong>To: </strong>devanshuagarwal, Stefan, asemke<br /><strong>Cc: \
</strong>sgerlach, kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic