[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D21841: Multiple datasets for money and smallnumbers activity
From: Johnny Jazeix <noreply () phabricator ! kde ! org>
Date: 2019-06-30 15:53:52
Message-ID: 58de6bb04300d0a3fc7fd717ed8d7909 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
jjazeix added a subscriber: echarruau.
jjazeix added a comment.
@echarruau can you please check the difficulty of the datasets and set the corresponding \
levels in "stars"? For example, for money_back, at last level, Tux has 100€ and needs to buy \
4 elements (21€, 59€, 50€ and 68€) and I'm not sure that it is not too complicated (at \
least for a 3 stars dataset). Same for money_cents and money_cents_back where there are also \
cents (so 49.06€, 164.09€, 25.02€ and 545.08€ for example) which seems quite difficult \
without calculator
@AkshayCHD please add in the README where you took the new images and their licences.
Have you tested your changes on android (phone or tablet?) to know if the layout is still \
working?
INLINE COMMENTS
> Gletters.qml:90
> + property var levels: activity.datasetLoader.item !== null ? \
> activity.datasetLoader.item.data : null + property var instructionText: ""
> property alias background: background
string?
> Gletters.qml:118
> + height: instructionTxt.contentHeight * 1.1
> + width: Math.max(Math.min(parent.width * 0.8, instructionTxt.text.length * 10), \
> parent.width * 0.3) + opacity: 0.8
parent.width * 0.3 seems to small, can you make it at least half of the screen?
> MoneyCore.qml:65
> + property int pocketRows
> + property var verticalOrientation: background.height > background.width - \
> bar.height property var selectedArea
bool?
> Data.qml:31
> + "level" : "1",
> + "objective" : "Select the number on dominoes up to 6",
> + "words" : [
qsTr() missing for all
> DialogChooseLevel.qml:207
> id: datasetOptionsRow
> - height: datasetVisibleButton.height
> + height: dialogChooseLevel.height / 12
> width: parent.width
just for my information, what do these changes fix?
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D21841
To: AkshayCHD, #gcompris_improvements
Cc: echarruau, jjazeix, kde-edu, #gcompris_improvements, sanjayshetty, parimalprasoon, \
harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, apol, \
timotheegiet, bcoudoin
[Attachment #3 (text/html)]
<table><tr><td style="">jjazeix added a subscriber: echarruau.<br />jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: \
#464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21841">View \
Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/echarruau/" \
style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> can you please check the difficulty of the \
datasets and set the corresponding levels in "stars"?<br /> For example, for \
money_back, at last level, Tux has 100€ and needs to buy 4 elements (21€, 59€, 50€ and \
68€) and I'm not sure that it is not too complicated (at least for a 3 stars \
dataset).<br /> Same for money_cents and money_cents_back where there are also cents (so \
49.06€, 164.09€, 25.02€ and 545.08€ for example) which seems quite difficult without \
calculator</p>
<p><a href="https://phabricator.kde.org/p/AkshayCHD/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@AkshayCHD</a> please add in the README where you took the new \
images and their licences.<br /> Have you tested your changes on android (phone or tablet?) to \
know if the layout is still working?</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D21841#inline-124908">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">Gletters.qml:90</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#004012">property</span> <span style="color: #aa4000">var</span> <span style="color: \
#aa4000">levels:</span> <span style="color: #004012">activity</span><span \
class="p">.</span><span style="color: #004012">datasetLoader</span><span \
class="p">.</span><span style="color: #004012">item</span> <span style="color: \
#aa2211">!==</span> <span style="color: #000a65">null</span> <span style="color: \
#aa2211">?</span> <span style="color: #aa4000">activity.datasetLoader.item.data :</span> <span \
style="color: #000a65">null</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span \
style="color: #aa4000">var</span> <span style="color: #aa4000">instructionText:</span> <span \
style="color: #766510">""</span> </div><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #004012">property</span> <span style="color: #004012">alias</span> <span \
style="color: #aa4000">background:</span> <span style="color: #004012">background</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">string?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: \
6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21841#inline-124918">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">Gletters.qml:118</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; \
clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">height:</span> <span \
style="color: #004012">instructionTxt</span><span class="p">.</span><span style="color: \
#004012">contentHeight</span> <span style="color: #aa2211">*</span> <span style="color: \
#601200">1.1</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: \
#304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span \
class="p">(</span><span style="color: #304a96">Math</span><span class="p">.</span><span \
style="color: #004012">min</span><span class="p">(</span><span style="color: \
#004012">parent</span><span class="p">.</span><span style="color: #004012">width</span> <span \
style="color: #aa2211">*</span> <span style="color: #601200">0.8</span><span class="p">,</span> \
<span style="color: #004012">instructionTxt</span><span class="p">.</span><span style="color: \
#004012">text</span><span class="p">.</span><span style="color: #004012">length</span> <span \
style="color: #aa2211">*</span> <span style="color: #601200">10</span><span class="p">),</span> \
<span style="color: #004012">parent</span><span class="p">.</span><span style="color: \
#004012">width</span> <span style="color: #aa2211">*</span> <span style="color: \
#601200">0.3</span><span class="p">)</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">opacity:</span> \
<span style="color: #601200">0.8</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">parent.width * \
0.3 seems to small, can you make it at least half of the screen?</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: \
#F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21841#inline-124907">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">MoneyCore.qml:65</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; \
clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span \
style="color: #304a96">int</span> <span style="color: #004012">pocketRows</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span \
style="color: #aa4000">verticalOrientation:</span> <span style="color: \
#004012">background</span><span class="p">.</span><span style="color: #004012">height</span> \
<span style="color: #aa2211">></span> <span style="color: #004012">background</span><span \
class="p">.</span><span style="color: #004012">width</span> <span style="color: \
#aa2211">-</span> <span style="color: #004012">bar</span><span class="p">.</span><span \
style="color: #004012">height</span> </div><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span \
style="color: #004012">selectedArea</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">bool?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: \
6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21841#inline-124906">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">Data.qml:31</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; \
clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #766510">"level"</span> <span \
style="color: #aa2211">:</span> <span style="color: #766510">"1"</span><span \
class="p">,</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #766510">"objective"</span> <span \
style="color: #aa2211">:</span> <span style="color: #766510">"Select the number on \
dominoes up to 6"</span><span class="p">,</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#766510">"words"</span> <span style="color: #aa2211">:</span> <span \
class="p">[</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qsTr() missing \
for all</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: \
6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21841#inline-124909">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">DialogChooseLevel.qml:207</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; \
clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #aa4000">id: datasetOptionsRow</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: \
#aa4000">height:</span> <span style="color: #004012">d<span \
class="bright">atasetVisibleButton</span></span><span class="p">.</span><span style="color: \
#004012">height</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, \
234, 151, .6);"> <span style="color: #aa4000">height:</span> <span style="color: \
#004012">d<span class="bright">ialogChooseLevel</span></span><span class="p">.</span><span \
style="color: #004012">height<span class="bright"></span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> \
</span><span style="color: #601200"><span class="bright">12</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#aa4000">width:</span> <span style="color: #004012">parent</span><span class="p">.</span><span \
style="color: #004012">width</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">just for my \
information, what do these changes fix?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D21841">https://phabricator.kde.org/D21841</a></div></div><br \
/><div><strong>To: </strong>AkshayCHD, GCompris: Improvements<br /><strong>Cc: \
</strong>echarruau, jjazeix, kde-edu, GCompris: Improvements, sanjayshetty, parimalprasoon, \
harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, apol, \
timotheegiet, bcoudoin<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic