[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D22097: Syntax correction in src/backend/hypothesisTest/
From:       Stefan Gerlach <noreply () phabricator ! kde ! org>
Date:       2019-06-26 20:10:15
Message-ID: e9999ae0739e27ffb9fc2ed6453a63e9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sgerlach added inline comments.

INLINE COMMENTS

> devanshuagarwal wrote in HypothesisTest.cpp:279
> How to decide which to use ? qSqrt or sqrt?

I would suggest to always choose the function with the minimum requirements. So C/C++ \
before GSL before Qt. This may not be always consistent right now, but most of time \
it ensures less conflicts and best portability.

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22097

To: devanshuagarwal, asemke, sgerlach
Cc: sgerlach, kde-edu, asemke, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D22097">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22097#inline-124516">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">devanshuagarwal</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:279</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">How to decide which to use ? qSqrt or sqrt?</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would suggest to \
always choose the function with the minimum requirements. So C/C++ before GSL before \
Qt. This may not be always consistent right now, but most of time it ensures less \
conflicts and best portability.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D22097">https://phabricator.kde.org/D22097</a></div></div><br \
/><div><strong>To: </strong>devanshuagarwal, asemke, sgerlach<br /><strong>Cc: \
</strong>sgerlach, kde-edu, asemke, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]