[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D21857: Levene Test Implementaion
From:       Stefan Gerlach <noreply () phabricator ! kde ! org>
Date:       2019-06-18 20:33:16
Message-ID: d9af6d8f9834a4de5eb32aeee34da353 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sgerlach added inline comments.

INLINE COMMENTS

> HypothesisTest.cpp:232
> +            }case ErrorEmptyColumn: {
> printError("At least one of selected column is empty");
> emit q->changed();

please translate all user visible messages

> HypothesisTest.cpp:239
> +
> +        QMapIterator<QString, int> i(col_name);
> +        while (i.hasNext()) {

better use "iter" or "nameIter". "i" should be only for counting integer.

> HypothesisTest.cpp:470
> +    int total_rows = 0;
> +    clearGlobalVariables();
> +

Do you really use global vars? Please avoid this and make this function  obsolete.

> HypothesisTest.cpp:473
> +    if (m_columns.size() != 2) {
> +        printError("Inappropriate number of columns selected");
> +        emit q->changed();

translate

> HypothesisTest.cpp:484
> +    if (np < 2) {
> +        printError("select atleast two columns/ classes");
> +        emit q->changed();

at least + translate

> HypothesisTest.cpp:525
> +            if (ni[i] > 0)
> +                yi_bar[i] = yi_bar[i] / ni[i];
> +        }

use "/="

> HypothesisTest.cpp:532
> +                if (!(std::isnan(value)))
> +                    zi_bar[i] += abs(value - yi_bar[i]);
> +            }

fabs() ?

> HypothesisTest.cpp:614
> +            zi_bar_bar += zi_bar[i];
> +            zi_bar[i] = zi_bar[i] / ni[i];
> +        }

"/="

> HypothesisTest.cpp:617
> +
> +        zi_bar_bar = zi_bar_bar / n;
> +

"/="

> HypothesisTest.cpp:670
> +
> +    printLine(0, "Null Hypothesis: Variance is equal between all classes", \
> "blue"); +    printLine(1, "Alternate Hypothesis: Variance is not equal in at-least \
> one pair of classes", "blue");

translation (2x)

> HypothesisTest.cpp:679
> +        q->m_view->setResultLine(5, i18n("We can safely reject Null Hypothesis for \
> significance level %1", m_significance_level), Qt::ToolTipRole); +        \
> printLine(8, "Requirement for homogeneity is not met", "red"); +    } else {

translation

> HypothesisTest.cpp:682
> +        q->m_view->setResultLine(5, i18n("There is a plausibility for Null \
> Hypothesis to be true"), Qt::ToolTipRole); +        printLine(8, "Requirement for \
> homogeneity is met", "green"); +    }

translation

> HypothesisTest.cpp:764
> 
> -HypothesisTestPrivate::ErrorType HypothesisTestPrivate::findStatsCategorical(const \
> Column *column1, const Column *column2, int n[], double sum[], double mean[], \
>                 double std[], QString &col1_name, QString &col2_name) {
> -    // clearing and initialising variables;
> +void HypothesisTestPrivate::countPartitions(Column *column, int &np, int \
> &total_rows) { +    total_rows = column->rowCount();

Column* column

> HypothesisTest.h:67
> 
> -    void performTwoSampleTTest();
> -    void performTwoSampleIndependentTTest(bool equal_variance);
> +    void performTwoSampleIndependentTTest(bool categorical_variable, bool \
> equal_variance); void performTwoSamplePairedTTest();

can you use camelCase for all variables? Just to make the naming style more \
consistent. I should have mentioned that before...

> HypothesisTestPrivate.h:42
> 
> enum TestType {TestT, TestZ};
> +        enum ErrorType {ErrorUnqualSize, ErrorEmptyColumn, NoError};

better "HypothesisTestType"?

> HypothesisTestPrivate.h:43
> enum TestType {TestT, TestZ};
> -        enum ErrorType {ErrorUnqualSize, ErrorNotTwoCategoricalVariables, \
> ErrorEmptyColumn, NoError}; +        enum ErrorType {ErrorUnqualSize, \
> ErrorEmptyColumn, NoError}; 

better "HypothesisErrorType"?

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D21857

To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, #labplot, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D21857">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123238">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:232</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">          \
<span class="p">}<span class="bright"></span></span><span class="bright"> \
</span><span style="color: #aa4000">case</span> <span style="color: \
#a0a000">Error<span class="bright">NotTwoCategoricalVariables</span></span><span \
class="p">:</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(251, 175, 175, .7);">                <span \
class="n">printError</span><span class="p">(</span> <span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">&quot;Number of Categorical Variable \
in Column %1 is not equal to 2&quot;</span><span class="p">,</span> <span \
class="n">m_columns</span><span class="p">[</span><span style="color: \
#601200">0</span><span class="p">]</span><span style="color: \
#aa2211">-&gt;</span><span class="n">name</span><span class="p">()));</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">                <span class="n">emit</span> <span class="n">q</span><span \
style="color: #aa2211">-&gt;</span><span class="n">changed</span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">                <span style="color: \
#aa4000">return</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span \
class="p">}</span> <span style="color: #aa4000">case</span> <span style="color: \
#a0a000">ErrorEmptyColumn</span><span class="p">:</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">            <span class="p">}</span><span style="color: #aa4000">case</span> \
<span style="color: #a0a000">Error<span class="bright">EmptyColumn</span></span><span \
class="p">:</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; ">                <span class="n">printError</span><span \
class="p">(</span><span style="color: #766510">&quot;At least one of selected column \
is empty&quot;</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">                <span class="n">emit</span> <span \
class="n">q</span><span style="color: #aa2211">-&gt;</span><span \
class="n">changed</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">please translate all user visible messages</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123235">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:239</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">QMapIterator</span><span style="color: #aa2211">&lt;</span><span \
class="n">QString</span><span class="p">,</span> <span style="color: \
#aa4000">int</span><span style="color: #aa2211">&gt;</span> <span \
class="n">i</span><span class="p">(</span><span class="n">col_name</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span style="color: #aa4000">while</span> <span \
class="p">(</span><span class="n">i</span><span class="p">.</span><span \
class="n">hasNext</span><span class="p">())</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">better use &quot;iter&quot; or &quot;nameIter&quot;. &quot;i&quot; \
should be only for counting integer.</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123236">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:470</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #aa4000">int</span> <span class="n">total_rows</span> <span \
style="color: #aa2211">=</span> <span style="color: #601200">0</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">clearGlobalVariables</span><span \
class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do \
you really use global vars? Please avoid this and make this function  \
obsolete.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D21857#inline-123239">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">HypothesisTest.cpp:473</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">m_columns</span><span \
class="p">.</span><span class="n">size</span><span class="p">()</span> <span \
style="color: #aa2211">!=</span> <span style="color: #601200">2</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">printError</span><span class="p">(</span><span style="color: \
#766510">&quot;Inappropriate number of columns selected&quot;</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">emit</span> <span \
class="n">q</span><span style="color: #aa2211">-&gt;</span><span \
class="n">changed</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">translate</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123237">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:484</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #aa4000">if</span> <span class="p">(</span><span class="n">np</span> \
<span style="color: #aa2211">&lt;</span> <span style="color: #601200">2</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">printError</span><span class="p">(</span><span style="color: \
#766510">&quot;select atleast two columns/ classes&quot;</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">emit</span> <span \
class="n">q</span><span style="color: #aa2211">-&gt;</span><span \
class="n">changed</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">at \
least + translate</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123240">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:525</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">ni</span><span class="p">[</span><span class="n">i</span><span \
class="p">]</span> <span style="color: #aa2211">&gt;</span> <span style="color: \
#601200">0</span><span class="p">)</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);">                <span \
class="n">yi_bar</span><span class="p">[</span><span class="n">i</span><span \
class="p">]</span> <span style="color: #aa2211">=</span> <span \
class="n">yi_bar</span><span class="p">[</span><span class="n">i</span><span \
class="p">]</span> <span style="color: #aa2211">/</span> <span \
class="n">ni</span><span class="p">[</span><span class="n">i</span><span \
class="p">];</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use \
&quot;/=&quot;</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123241">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:532</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span class="p">(</span><span class="n">std</span><span \
style="color: #aa2211">::</span><span class="n">isnan</span><span \
class="p">(</span><span class="n">value</span><span class="p">)))</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span class="n">zi_bar</span><span class="p">[</span><span class="n">i</span><span \
class="p">]</span> <span style="color: #aa2211">+=</span> <span \
class="n">abs</span><span class="p">(</span><span class="n">value</span> <span \
style="color: #aa2211">-</span> <span class="n">yi_bar</span><span \
class="p">[</span><span class="n">i</span><span class="p">]);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">fabs() ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123242">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:614</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span class="n">zi_bar_bar</span> <span style="color: #aa2211">+=</span> <span \
class="n">zi_bar</span><span class="p">[</span><span class="n">i</span><span \
class="p">];</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">            <span class="n">zi_bar</span><span \
class="p">[</span><span class="n">i</span><span class="p">]</span> <span \
style="color: #aa2211">=</span> <span class="n">zi_bar</span><span \
class="p">[</span><span class="n">i</span><span class="p">]</span> <span \
style="color: #aa2211">/</span> <span class="n">ni</span><span \
class="p">[</span><span class="n">i</span><span class="p">];</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">&quot;/=&quot;</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123243">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:617</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">zi_bar_bar</span> <span style="color: #aa2211">=</span> <span \
class="n">zi_bar_bar</span> <span style="color: #aa2211">/</span> <span \
class="n">n</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">&quot;/=&quot;</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123244">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:670</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">printLine</span><span class="p">(</span><span style="color: \
#601200">0</span><span class="p">,</span> <span style="color: #766510">&quot;Null \
Hypothesis: Variance is equal between all classes&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;blue&quot;</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">printLine</span><span \
class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span \
style="color: #766510">&quot;Alternate Hypothesis: Variance is not equal in at-least \
one pair of classes&quot;</span><span class="p">,</span> <span style="color: \
#766510">&quot;blue&quot;</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">translation (2x)</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123245">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:679</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">q</span><span style="color: #aa2211">-&gt;</span><span \
class="n">m_view</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setResultLine</span><span class="p">(</span><span style="color: \
#601200">5</span><span class="p">,</span> <span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">&quot;We can safely reject Null \
Hypothesis for significance level %1&quot;</span><span class="p">,</span> <span \
class="n">m_significance_level</span><span class="p">),</span> <span \
class="n">Qt</span><span style="color: #aa2211">::</span><span \
class="n">ToolTipRole</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">printLine</span><span class="p">(</span><span style="color: \
#601200">8</span><span class="p">,</span> <span style="color: \
#766510">&quot;Requirement for homogeneity is not met&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;red&quot;</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: \
#aa4000">else</span> <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">translation</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123246">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:682</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">q</span><span style="color: #aa2211">-&gt;</span><span \
class="n">m_view</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setResultLine</span><span class="p">(</span><span style="color: \
#601200">5</span><span class="p">,</span> <span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">&quot;There is a plausibility for Null \
Hypothesis to be true&quot;</span><span class="p">),</span> <span \
class="n">Qt</span><span style="color: #aa2211">::</span><span \
class="n">ToolTipRole</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">printLine</span><span class="p">(</span><span style="color: \
#601200">8</span><span class="p">,</span> <span style="color: \
#766510">&quot;Requirement for homogeneity is met&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;green&quot;</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">translation</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123247">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:764</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span \
class="bright"></span><span class="n"><span \
class="bright">HypothesisTestPrivate</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">ErrorType</span></span><span class="bright"> </span><span \
class="n"><span class="bright">HypothesisTestPrivate</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">::</span></span><span class="bright"></span><span class="n"><span \
class="bright">findStatsCategorical</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> \
</span><span class="n"><span class="bright">Column</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">*</span></span><span \
class="bright"></span><span class="n"><span class="bright">column1</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">const</span></span><span class="bright"> </span><span class="n"><span \
class="bright">Column</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">*</span></span><span class="bright"></span><span \
class="n"><span class="bright">column2</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> \
</span><span class="n"><span class="bright">n</span></span><span \
class="bright"></span><span class="p"><span class="bright">[],</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">double</span></span><span class="bright"> </span><span class="n"><span \
class="bright">sum</span></span><span class="bright"></span><span class="p"><span \
class="bright">[],</span></span><span class="bright"> </span><span style="color: \
#aa4000"><span class="bright">double</span></span><span class="bright"> </span><span \
class="n"><span class="bright">mean</span></span><span class="bright"></span><span \
class="p"><span class="bright">[],</span></span><span class="bright"> </span><span \
style="color: #aa4000"><span class="bright">double</span></span><span class="bright"> \
</span><span class="n"><span class="bright">std</span></span><span \
class="bright"></span><span class="p"><span class="bright">[],</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QString</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">&amp;</span></span><span class="bright"></span><span \
class="n"><span class="bright">col1_name</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QString</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">&amp;</span></span><span class="bright"></span><span \
class="n"><span class="bright">col2_name</span></span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: \
#74777d"><span class="bright">// clearing and initialising variables</span>;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="bright"></span><span style="color: #aa4000"><span \
class="bright">void</span></span><span class="bright"> </span><span class="n"><span \
class="bright">HypothesisTestPrivate</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">countPartitions</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">Column</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">*</span></span><span \
class="bright"></span><span class="n"><span class="bright">column</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">int</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">&amp;</span></span><span class="bright"></span><span \
class="n"><span class="bright">np</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">&amp;</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">total_rows</span></span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span \
class="bright">total_rows</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span class="n"><span class="bright">column</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-&gt;</span></span><span class="bright"></span><span class="n"><span \
class="bright">rowCount</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Column* column</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123233">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.h:67</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
style="color: #aa4000">void</span> <span style="color: \
#004012">performTwoSampleTTest</span><span class="p">();</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
style="color: #aa4000">void</span> <span style="color: \
#004012">performTwoSampleIndependentTTest</span><span class="p">(</span><span \
style="color: #aa4000">bool</span> <span class="n">equal_variance</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span \
style="color: #004012">performTwoSample<span \
class="bright">Independent</span>TTest</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span \
class="n"><span class="bright">categorical_variable</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">bool</span></span><span class="bright"> </span><span class="n"><span \
class="bright">equal_variance</span></span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">void</span> \
<span style="color: #004012">performTwoSamplePairedTTest</span><span \
class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">can \
you use camelCase for all variables? Just to make the naming style more consistent. I \
should have mentioned that before...</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123248">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTestPrivate.h:42</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: \
#aa4000">enum</span> <span class="n">TestType</span> <span class="p">{</span><span \
class="n">TestT</span><span class="p">,</span> <span class="n">TestZ</span><span \
class="p">};</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">        <span style="color: #aa4000">enum</span> <span \
class="n">ErrorType</span> <span class="p">{</span><span \
class="n">ErrorUnqualSize</span><span class="p">,</span> <span class="n">Error<span \
class="bright">NotTwoCategoricalVariables</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">Error</span>EmptyColumn</span><span class="p">,</span> <span \
class="n">NoError</span><span class="p">};</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">enum</span> <span class="n">ErrorType</span> <span class="p">{</span><span \
class="n">ErrorUnqualSize</span><span class="p">,</span> <span \
class="n">ErrorEmptyColumn</span><span class="p">,</span> <span \
class="n">NoError</span><span class="p">};</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">better &quot;HypothesisTestType&quot;?</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21857#inline-123250">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTestPrivate.h:43</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: \
#aa4000">enum</span> <span class="n">TestType</span> <span class="p">{</span><span \
class="n">TestT</span><span class="p">,</span> <span class="n">TestZ</span><span \
class="p">};</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">        <span style="color: #aa4000">enum</span> <span \
class="n">ErrorType</span> <span class="p">{</span><span \
class="n">ErrorUnqualSize</span><span class="p">,</span> <span class="n">Error<span \
class="bright">NotTwoCategoricalVariables</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">Error</span>EmptyColumn</span><span class="p">,</span> <span \
class="n">NoError</span><span class="p">};</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">enum</span> <span class="n">ErrorType</span> <span class="p">{</span><span \
class="n">ErrorUnqualSize</span><span class="p">,</span> <span \
class="n">ErrorEmptyColumn</span><span class="p">,</span> <span \
class="n">NoError</span><span class="p">};</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">better &quot;HypothesisErrorType&quot;?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D21857">https://phabricator.kde.org/D21857</a></div></div><br \
/><div><strong>To: </strong>devanshuagarwal, sgerlach, asemke<br /><strong>Cc: \
</strong>kde-edu, LabPlot, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]