[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D21684: Hypothesis test: Dock and View for t test and z test
From: Stefan Gerlach <noreply () phabricator ! kde ! org>
Date: 2019-06-11 14:07:28
Message-ID: 98c6481fe84e834cdc56dca8f73989c8 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
sgerlach added inline comments.
INLINE COMMENTS
> HypothesisTest.cpp:97
> +}
> +
> +void HypothesisTest::setSignificanceLevel(QVariant alpha) {
with or without "()"?
> HypothesisTest.cpp:102
> +
> +void HypothesisTest::setTailType(HypothesisTest::TailType tailType) {
> + d->tail_type = tailType;
QString::isEmpty()
> HypothesisTest.cpp:160
> HypothesisTestPrivate::HypothesisTestPrivate(HypothesisTest* owner) : q(owner) ,
> dataModel(new QStandardItemModel) ,
> + horizontalHeaderModel(new QStandardItemModel) ,
please indent to make it more readable.
> HypothesisTest.cpp:166
>
> HypothesisTestPrivate::~HypothesisTestPrivate() {
better "t_value"?
> HypothesisTest.cpp:171
why 9?
> HypothesisTest.cpp:786
This header text should be defined separately to make the code more readable.
> HypothesisTestView.cpp:62
> + m_testName(new QLabel()),
> + m_statsTable(new QLabel()),
> + m_resultView(new QListView(this)) {
please add TODO comments for missing implementations.
> HypothesisTestView.h:8
The indentation looks strange here.
REPOSITORY
R262 LabPlot
REVISION DETAIL
https://phabricator.kde.org/D21684
To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, #labplot, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; \
font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D21684">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: \
solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21684#inline-122367">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">HypothesisTest.cpp:97</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #aa4000">void</span> <span class="n">HypothesisTest</span><span style="color: \
#aa2211">::</span><span class="n">setSignificanceLevel</span><span class="p">(</span><span \
class="n">QVariant</span> <span class="n">alpha</span><span class="p">)</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">with \
or without "()"?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21684#inline-122368">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">HypothesisTest.cpp:102</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #aa4000">void</span> <span class="n">HypothesisTest</span><span style="color: \
#aa2211">::</span><span class="n">setTailType</span><span class="p">(</span><span \
class="n">HypothesisTest</span><span style="color: #aa2211">::</span><span class="n">TailType</span> \
<span class="n">tailType</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">d</span><span style="color: #aa2211">-></span><span class="n">tail_type</span> <span \
style="color: #aa2211">=</span> <span class="n">tailType</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">QString::isEmpty()</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21684#inline-122369">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">HypothesisTest.cpp:160</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span \
class="n">HypothesisTestPrivate</span><span style="color: #aa2211">::</span><span \
class="n">HypothesisTestPrivate</span><span class="p">(</span><span class="n">HypothesisTest</span><span \
style="color: #aa2211">*</span> <span class="n">owner</span><span class="p">)</span> <span style="color: \
#aa2211">:</span> <span class="n">q</span><span class="p">(</span><span class="n">owner</span><span \
class="p">)</span> <span class="p">,</span> </div><div style="padding: 0 8px; margin: 0 4px; "> <span \
class="n">dataModel</span><span class="p">(</span><span style="color: #aa4000">new</span> <span \
class="n">QStandardItemModel</span><span class="p">)</span> <span class="p">,</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="n">horizontalHeaderModel</span><span class="p">(</span><span style="color: #aa4000">new</span> \
<span class="n">QStandardItemModel</span><span class="p">)</span> <span class="bright"></span><span \
class="p"><span class="bright">{</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span class="n">horizontalHeaderModel</span><span \
class="p">(</span><span style="color: #aa4000">new</span> <span class="n">QStandardItemModel</span><span \
class="p">)</span> <span class="bright"></span><span class="p"><span class="bright">,</span></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">please indent to make it more readable.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: \
solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21684#inline-122371">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">HypothesisTest.cpp:166</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span \
class="n">HypothesisTestPrivate</span><span style="color: #aa2211">::~</span><span \
class="n">HypothesisTestPrivate</span><span class="p">()</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">better "t_value"?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: \
solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21684#inline-122370">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">HypothesisTest.cpp:171</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; color: #888888;">(Empty.)</div></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why 9?</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: \
#F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D21684#inline-122372">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:786</span></div> <div style="font: \
11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; \
clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; color: \
#888888;">(Empty.)</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This header text should be defined separately to make the code more \
readable.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px \
0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21684#inline-122366">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTestView.cpp:62</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_t<span \
class="bright">ableView</span></span><span class="p">(</span><span style="color: #aa4000">new</span> \
<span class="n">Q<span class="bright">TableView</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: \
#aa4000"><span class="bright">this</span></span><span class="p">)),</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_<span \
class="bright">horizontalHeaderView</span></span><span class="p">(</span><span style="color: \
#aa4000">new</span> <span class="n">Q<span class="bright">HeaderView</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span class="bright">Qt</span></span><span \
class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span class="bright">Horizontal</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> \
</span><span class="n"><span class="bright">m_tableView</span></span><span class="p">)),</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="n">m_<span class="bright">testName</span></span><span class="p">(</span><span style="color: \
#aa4000">new</span> <span class="n">QL<span class="bright">abel</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span>))</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">m_t<span class="bright">estName</span></span><span class="p">(</span><span style="color: \
#aa4000">new</span> <span class="n">Q<span class="bright">Label</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span>)),</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_<span \
class="bright">statsTable</span></span><span class="p">(</span><span style="color: #aa4000">new</span> \
<span class="n">Q<span class="bright">Label</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span>)),</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span class="n">m_<span \
class="bright">resultView</span></span><span class="p">(</span><span style="color: #aa4000">new</span> \
<span class="n">QL<span class="bright">istView</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: \
#aa4000"><span class="bright">this</span></span><span class="p">))</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">please add TODO comments for missing implementations.</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: \
#eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21684#inline-122365">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">HypothesisTestView.h:8</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; color: #888888;">(Empty.)</div></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The indentation looks strange \
here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 \
LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D21684">https://phabricator.kde.org/D21684</a></div></div><br \
/><div><strong>To: </strong>devanshuagarwal, sgerlach, asemke<br /><strong>Cc: </strong>kde-edu, LabPlot, \
narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic