[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D21212: Remove DBus from Python backend
From:       Nikita Sirgienko <noreply () phabricator ! kde ! org>
Date:       2019-05-20 9:16:04
Message-ID: af2d9996997723eba5c9567871157933 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sirgienko added inline comments.

INLINE COMMENTS

> asemke wrote in pythonexpression.cpp:128
> MaximaExpression::imageChanged() has a different logic and implementation. Can we \
> try to unify the handling here?

Not sure. `MaximaExpression` knows, where image placed, and `imageChanged()` handle \
this. Also, in maxima output there is placeholder for image. `PythonExpression` has \
another conditions, so the code different from `MaximaExpression` code. So, in this \
moment, I don't see general logic for both classes.

> sirgienko wrote in pythonvariablemodel.cpp:49
> You right, the variable not needed, I just had forggoten to remove it.

I had mistaken, this variable contains value about `variableManagement` (enabled or \
not) from python settings. `PythonSession` haven't own settings, so we need use \
session method.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D21212

To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">sirgienko added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D21212">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21212#inline-119354">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">asemke</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">pythonexpression.cpp:128</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">MaximaExpression::imageChanged() has a different logic and implementation. Can \
we try to unify the handling here?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not sure. <tt \
style="background: #ebebeb; font-size: 13px;">MaximaExpression</tt> knows, where \
image placed, and <tt style="background: #ebebeb; font-size: \
13px;">imageChanged()</tt> handle this. Also, in maxima output there is placeholder \
for image.<br /> <tt style="background: #ebebeb; font-size: \
13px;">PythonExpression</tt> has another conditions, so the code different from <tt \
style="background: #ebebeb; font-size: 13px;">MaximaExpression</tt> code.<br /> So, \
in this moment, I don&#039;t see general logic for both classes.</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D21212#inline-119362">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">sirgienko</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">pythonvariablemodel.cpp:49</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">You right, the variable not needed, I just had forggoten to remove \
it.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">I had mistaken, this variable contains value about <tt \
style="background: #ebebeb; font-size: 13px;">variableManagement</tt> (enabled or \
not) from python settings. <tt style="background: #ebebeb; font-size: \
13px;">PythonSession</tt> haven&#039;t own settings, so we need use session \
method.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D21212">https://phabricator.kde.org/D21212</a></div></div><br \
/><div><strong>To: </strong>sirgienko, asemke<br /><strong>Cc: </strong>kde-edu, \
asemke, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]