[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D20150: Meridian flip checks after capture completion removed
From:       Wolfgang Reissenberger <noreply () phabricator ! kde ! org>
Date:       2019-03-31 20:27:54
Message-ID: 999cf23c6a6ee1ca9d8eaad8facf7c83 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, TallFurryMan.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  Meridian flip checks only take place before a capture is planned and not also after \
a capture has been completed. This is necessary to avoid problems with the meridian \
flip directly after the last capture of a capturing job has been completed.

TEST PLAN
  - Bug fix test: create a capture job with several single capture sequences. Use \
this job in a scheduler where aligning and guiding is enabled and the mount position \
is close to the meridian. Expected result is, that the sequence is interrupted by a \
meridian flip and after the meridian flip, re-aligning and restart of guiding happens \
                and the imaging session is continued.
  - Regression tests: Test meridian flip behaviour with scheduler running, capturing \
without scheduler and with an idle mount.

REPOSITORY
  R321 KStars

BRANCH
  precapture_meridian_flip

REVISION DETAIL
  https://phabricator.kde.org/D20150

AFFECTED FILES
  kstars/ekos/capture/capture.cpp

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">wreissenberger created this revision.<br />wreissenberger \
added reviewers: mutlaqja, TallFurryMan.<br />Herald added a project: KDE Edu.<br \
/>Herald added a subscriber: kde-edu.<br />wreissenberger requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D20150">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Meridian flip checks only take place \
before a capture is planned and not also after a capture has been completed. This is \
necessary to avoid problems with the meridian flip directly after the last capture of \
a capturing job has been completed.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><ul class="remarkup-list"> <li class="remarkup-list-item">Bug fix \
test: create a capture job with several single capture sequences. Use this job in a \
scheduler where aligning and guiding is enabled and the mount position is close to \
the meridian. Expected result is, that the sequence is interrupted by a meridian flip \
and after the meridian flip, re-aligning and restart of guiding happens and the \
imaging session is continued.</li> <li class="remarkup-list-item">Regression tests: \
Test meridian flip behaviour with scheduler running, capturing without scheduler and \
with an idle mount.</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>precapture_meridian_flip</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D20150">https://phabricator.kde.org/D20150</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kstars/ekos/capture/capture.cpp</div></div></div><br \
/><div><strong>To: </strong>wreissenberger, mutlaqja, TallFurryMan<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]