[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D19330: fix failing DMS-String parsing on windows
From:       Martin Koller <noreply () phabricator ! kde ! org>
Date:       2019-02-26 10:30:37
Message-ID: fa8f68ed82bc6b99b403c1e2e216b28c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mkoller created this revision.
mkoller added reviewers: Marble: General, rahn, nienhueser, kossebau.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
mkoller requested review of this revision.

REVISION SUMMARY
  This patch marks unicode strings so that the compiler (on windows) can correctly \
use them.  
  Without the patch, ~6000 tests failed for the TestGeoDataCoordinates,
  with the patch zero.

TEST PLAN
  tested on windows and Linux

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D19330

AFFECTED FILES
  lib/marble/geodata/data/LonLatParser.cpp

To: mkoller, #marble_general, rahn, nienhueser, kossebau
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, \
narvaez, cmihalache, rahn, apol, nienhueser


[Attachment #3 (text/html)]

<table><tr><td style="">mkoller created this revision.<br />mkoller added reviewers: \
Marble: General, rahn, nienhueser, kossebau.<br />Herald added projects: Marble, KDE \
Edu.<br />Herald added subscribers: kde-edu, marble-devel.<br />mkoller requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D19330">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>This patch marks unicode strings so \
that the compiler (on windows) can correctly use them.</p>

<p>Without the patch, ~6000 tests failed for the TestGeoDataCoordinates,<br />
with the patch zero.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>tested on windows and Linux</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R34 Marble</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D19330">https://phabricator.kde.org/D19330</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>lib/marble/geodata/data/LonLatParser.cpp</div></div></div><br \
/><div><strong>To: </strong>mkoller, Marble: General, rahn, nienhueser, kossebau<br \
/><strong>Cc: </strong>marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, \
chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]