[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D19095: Adding new Variable models for few backends
From:       Alexander Semke <noreply () phabricator ! kde ! org>
Date:       2019-02-25 7:25:48
Message-ID: 1bfcf14a960e5f1c29786b67b8dde5f8 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

asemke added inline comments.

INLINE COMMENTS

> rsession.cpp:153
> 
> if(expressionQueue().isEmpty())
> +            if (m_needUpdate)

This logic seems to be the (almost) the same for all session classes. Can we move \
this maybe to Session.cpp? E.g. to Session::statusChanged()? With this we don't need \
to touch all the session classes now and to add this m_needUpdate variable \
everywhere.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D19095

To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D19095">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D19095#inline-107676">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">rsession.cpp:153</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">        <span style="color: \
#aa4000">if</span><span class="p">(</span><span class="n">expressionQueue</span><span \
class="p">().</span><span class="n">isEmpty</span><span class="p">())</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">            <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">m_needUpdate</span><span class="p">)</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This logic seems to be the (almost) the same for all session classes. \
Can we move this maybe to Session.cpp? E.g. to Session::statusChanged()? With this we \
don&#039;t need to touch all the session classes now and to add this m_needUpdate \
variable everywhere.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D19095">https://phabricator.kde.org/D19095</a></div></div><br \
/><div><strong>To: </strong>sirgienko, asemke<br /><strong>Cc: </strong>kde-edu, \
asemke, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]