[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D19231: update default server to kde one to download data
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2019-02-22 19:37:02
Message-ID: 26c87787f10faeea964684141e2b3551 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jjazeix added inline comments.

INLINE COMMENTS

> apol wrote in ApplicationSettings.cpp:157
> these are char* so == doesn't work.
> 
> Make them (or at least either) a QLatin1String, otherwise you'll be comparing \
> pointers.

m_downloadServerUrl is a QString and there is a operator==(const char *) \
(https://doc.qt.io/qt-5/qstring.html#operator-eq-eq-1) so it is fine?

REVISION DETAIL
  https://phabricator.kde.org/D19231

To: jjazeix, #gcompris_improvements
Cc: apol, kde-edu, narvaez


[Attachment #3 (text/html)]

<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D19231">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D19231#inline-107381">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">ApplicationSettings.cpp:157</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">these are char* so == doesn&#039;t work.</p>

<p style="padding: 0; margin: 8px;">Make them (or at least either) a QLatin1String, \
otherwise you&#039;ll be comparing pointers.</p></div></div> <div style="margin: 8px \
0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">m_downloadServerUrl is a \
QString and there is a operator==(const char *) (<a \
href="https://doc.qt.io/qt-5/qstring.html#operator-eq-eq-1" class="remarkup-link" \
target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qstring.html#operator-eq-eq-1</a>) \
so it is fine?</p></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D19231">https://phabricator.kde.org/D19231</a></div></div><br \
/><div><strong>To: </strong>jjazeix, GCompris: Improvements<br /><strong>Cc: \
</strong>apol, kde-edu, narvaez<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]