[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D17861: Prevent instructions from disappearing
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2019-02-14 9:06:54
Message-ID: fa8a09ce6c4ca7f811877591913a62ae () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jjazeix added a comment.


  When the instruction is displayed, clicking on a candy already placed in the grid \
makes the instruction disappear (and thus, causing a move on the child widgets which \
is not expected, as we may want to remove several candies at same time without having \
to move the mouse).  When you change level, if the text was not elided in the \
previous level, at first time, you need to click twice to have the elide work, can \
you please fix it (I'm not sure but maybe the binding will fix it)?

INLINE COMMENTS

> Share.qml:239
> +                        grid.opacity = 0
> +                        instructionTxt.elide = Text.ElideNone
> +                    } else {

can't elide property binded directly to grid.opacity?
elide: grid.opacity == 1 ? Text.ElideRight :  Text.ElideNone

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17861

To: AkshayCHD, #gcompris_improvements
Cc: echarruau, jjazeix, kde-edu, #gcompris_improvements, parimalprasoon, harrymecwan, \
ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, timotheegiet, \
bcoudoin


[Attachment #3 (text/html)]

<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17861">View Revision</a></tr></table><br \
/><div><div><p>When the instruction is displayed, clicking on a candy already placed \
in the grid makes the instruction disappear (and thus, causing a move on the child \
widgets which is not expected, as we may want to remove several candies at same time \
without having to move the mouse).<br /> When you change level, if the text was not \
elided in the previous level, at first time, you need to click twice to have the \
elide work, can you please fix it (I&#039;m not sure but maybe the binding will fix \
it)?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D17861#inline-105855">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">Share.qml:239</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">                        <span style="color: #004012">grid</span><span \
class="p">.</span><span style="color: #004012">opacity</span> <span style="color: \
#aa2211">=</span> <span style="color: #601200">0</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        \
<span style="color: #004012">instructionTxt</span><span class="p">.</span><span \
style="color: #004012">elide</span> <span style="color: #aa2211">=</span> <span \
style="color: #004012">Text</span><span class="p">.</span><span style="color: \
#004012">ElideNone</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">                    <span class="p">}</span> \
<span style="color: #aa4000">else</span> <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
                8px;">can&#039;t elide property binded directly to grid.opacity?<br \
                />
elide: grid.opacity == 1 ? Text.ElideRight :  \
Text.ElideNone</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17861">https://phabricator.kde.org/D17861</a></div></div><br \
/><div><strong>To: </strong>AkshayCHD, GCompris: Improvements<br /><strong>Cc: \
</strong>echarruau, jjazeix, kde-edu, GCompris: Improvements, parimalprasoon, \
harrymecwan, ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, \
timotheegiet, bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]